You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/04/10 09:12:52 UTC

[GitHub] chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
URL: https://github.com/apache/incubator-openwhisk/pull/3517#issuecomment-380030492
 
 
   This PR is now ready for review. 
   
   In a [separate branch][1] travis run was done with default `ArtifactStoreProvider` switched `MemoryArtifactStoreProvider` and all test (except few<sup>1</sup>) have passed. 
   
   `ArtifactStoreBehavior` test suite consist of ~30 tests which try to cover all possible access patterns for `ArtifactStore` and provides [a coverage][3] of ~86%
   
   
   <sup>1</sup> 2 test needed to be ignored for run involving MemoryArtifactStore. See [commit notes][2] for details
   
   [1]: https://github.com/chetanmeh/incubator-openwhisk/commit/e19c651cac9d2588b94a938ca0e65b16c0c76c44
   [2]: https://github.com/apache/incubator-openwhisk/pull/3517/commits/75df4c63e42f27479615489b7e5a51219b56ae41
   [3]: https://github.com/chetanmeh/incubator-openwhisk/pull/2#issuecomment-379660015

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services