You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Glen Mazza <gl...@verizon.net> on 2007/10/05 14:43:50 UTC

Re: svn commit: r582082 - in /incubator/cxf/trunk: common/common/src/main/java/org/apache/cxf/common/injection/ systests/src/test/java/org/apache/cxf/systest/http_jetty/

Am Freitag, den 05.10.2007, 05:49 +0000 schrieb ningjiang@apache.org:
> Author: ningjiang
> Date: Thu Oct  4 22:49:08 2007
> New Revision: 582082
> 
> URL: http://svn.apache.org/viewvc?rev=582082&view=rev
> Log:
> CXF-1086 got the http-jetty systest worked and also  fixed the jaxws
> unitest failures which were caused by my last commit
> 
> Added:
> incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http_jetty/EngineLifecycleTest.java
> URL:
> http://svn.apache.org/viewvc/incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http_jetty/EngineLifecycleTest.java?rev=582082&view=auto
> ==============================================================================
> --- +    
> +    private void invokeService() {        
> +        DummyInterface client = (DummyInterface) applicationContext.getBean("dummy-client");
> +        assertEquals("We should get out put from this client", "hello world", client.echo("hello world"));

output

> +   
> +
> +    public void shutdownService() throws Exception {        
> +        applicationContext.destroy();
> +        applicationContext.close();        

Do you really need to call destroy()[1]?  The API seems to indicate that
close() (also[1]) alone is sufficient.

[1]
http://www.springframework.org/docs/api/org/springframework/context/support/AbstractApplicationContext.html#destroy()


Regards,
Glen



RE: svn commit: r582082 - in /incubator/cxf/trunk:common/common/src/main/java/org/apache/cxf/common/injection/systests/src/test/java/org/apache/cxf/systest/http_jetty/

Posted by Benson Margulies <bi...@basistech.com>.
That was me, and I was throwing everything I could find at it.

> -----Original Message-----
> From: Glen Mazza [mailto:glen.mazza@verizon.net]
> Sent: Friday, October 05, 2007 8:44 AM
> To: cxf-dev@incubator.apache.org
> Subject: Re: svn commit: r582082 - in
>
/incubator/cxf/trunk:common/common/src/main/java/org/apache/cxf/common/i
nj
> ection/systests/src/test/java/org/apache/cxf/systest/http_jetty/
> 
> Am Freitag, den 05.10.2007, 05:49 +0000 schrieb ningjiang@apache.org:
> > Author: ningjiang
> > Date: Thu Oct  4 22:49:08 2007
> > New Revision: 582082
> >
> > URL: http://svn.apache.org/viewvc?rev=582082&view=rev
> > Log:
> > CXF-1086 got the http-jetty systest worked and also  fixed the jaxws
> > unitest failures which were caused by my last commit
> >
> > Added:
> >
>
incubator/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/http_j
et
> ty/EngineLifecycleTest.java
> > URL:
> >
>
http://svn.apache.org/viewvc/incubator/cxf/trunk/systests/src/test/java/
or
>
g/apache/cxf/systest/http_jetty/EngineLifecycleTest.java?rev=582082&view
=a
> uto
> >
>
========================================================================
==
> ====
> > --- +
> > +    private void invokeService() {
> > +        DummyInterface client = (DummyInterface)
> applicationContext.getBean("dummy-client");
> > +        assertEquals("We should get out put from this client",
"hello
> world", client.echo("hello world"));
> 
> output
> 
> > +
> > +
> > +    public void shutdownService() throws Exception {
> > +        applicationContext.destroy();
> > +        applicationContext.close();
> 
> Do you really need to call destroy()[1]?  The API seems to indicate
that
> close() (also[1]) alone is sufficient.
> 
> [1]
>
http://www.springframework.org/docs/api/org/springframework/context/supp
or
> t/AbstractApplicationContext.html#destroy()
> 
> 
> Regards,
> Glen
>