You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Stefan Zoerner (JIRA)" <ji...@apache.org> on 2007/05/10 16:43:15 UTC

[jira] Created: (DIRSTUDIO-100) Interface IRootDSE does not sufficiently define return values of methods

Interface IRootDSE does not sufficiently define return values of methods
------------------------------------------------------------------------

                 Key: DIRSTUDIO-100
                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-100
             Project: Directory LDAP Studio
          Issue Type: Wish
            Reporter: Stefan Zoerner
             Fix For: 0.8.0


I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods

* getSupportedExtensions
* getSupportedControls
* getSupportedFeatures

Do they return the OIDs, or a name, or a description (what language)? 
The implementation 
org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSTUDIO-100) Interface IRootDSE does not sufficiently define return values of methods

Posted by "Stefan Zoerner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSTUDIO-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495014 ] 

Stefan Zoerner commented on DIRSTUDIO-100:
------------------------------------------

I have removed the translation from OIDs from the implementing class (will be moved to UI class and changed to a ResourceBundle).

http://svn.apache.org/viewvc?view=rev&revision=537147
http://svn.apache.org/viewvc?view=rev&revision=537150

> Interface IRootDSE does not sufficiently define return values of methods
> ------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-100
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-100
>             Project: Directory LDAP Studio
>          Issue Type: Wish
>            Reporter: Stefan Zoerner
>         Assigned To: Stefan Zoerner
>             Fix For: 0.8.0
>
>
> I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods
> * getSupportedExtensions
> * getSupportedControls
> * getSupportedFeatures
> Do they return the OIDs, or a name, or a description (what language)? 
> The implementation 
> org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
> for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DIRSTUDIO-100) Interface IRootDSE does not sufficiently define return values of methods

Posted by "Stefan Zoerner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSTUDIO-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Zoerner reassigned DIRSTUDIO-100:
----------------------------------------

    Assignee: Stefan Zoerner

> Interface IRootDSE does not sufficiently define return values of methods
> ------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-100
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-100
>             Project: Directory LDAP Studio
>          Issue Type: Wish
>            Reporter: Stefan Zoerner
>         Assigned To: Stefan Zoerner
>             Fix For: 0.8.0
>
>
> I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods
> * getSupportedExtensions
> * getSupportedControls
> * getSupportedFeatures
> Do they return the OIDs, or a name, or a description (what language)? 
> The implementation 
> org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
> for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRSTUDIO-100) Interface IRootDSE does not sufficiently define return values of methods

Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSTUDIO-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre-Arnaud Marcelot updated DIRSTUDIO-100:
---------------------------------------------

    Fix Version/s:     (was: 0.9.0)
                   1.0.0

> Interface IRootDSE does not sufficiently define return values of methods
> ------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-100
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-100
>             Project: Directory Studio
>          Issue Type: Wish
>            Reporter: Stefan Zoerner
>            Assignee: Stefan Zoerner
>             Fix For: 1.0.0
>
>
> I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods
> * getSupportedExtensions
> * getSupportedControls
> * getSupportedFeatures
> Do they return the OIDs, or a name, or a description (what language)? 
> The implementation 
> org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
> for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRSTUDIO-100) Interface IRootDSE does not sufficiently define return values of methods

Posted by "Stefan Zoerner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSTUDIO-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Zoerner closed DIRSTUDIO-100.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.8.0)
                   0.9.0

> Interface IRootDSE does not sufficiently define return values of methods
> ------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-100
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-100
>             Project: Directory LDAP Studio
>          Issue Type: Wish
>            Reporter: Stefan Zoerner
>         Assigned To: Stefan Zoerner
>             Fix For: 0.9.0
>
>
> I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods
> * getSupportedExtensions
> * getSupportedControls
> * getSupportedFeatures
> Do they return the OIDs, or a name, or a description (what language)? 
> The implementation 
> org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
> for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSTUDIO-100) Interface IRootDSE does not sufficiently define return values of methods

Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSTUDIO-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494852 ] 

Stefan Seelmann commented on DIRSTUDIO-100:
-------------------------------------------

Stefan, you are totally right. The interface lacks on documentation and the RootDSE class implementation is bad. Thanks for heads up. As you suggest the best way would be to return the OIDs only. BTW, the methods are only used from the RootDSEPropertyPage.

> Interface IRootDSE does not sufficiently define return values of methods
> ------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-100
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-100
>             Project: Directory LDAP Studio
>          Issue Type: Wish
>            Reporter: Stefan Zoerner
>             Fix For: 0.8.0
>
>
> I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods
> * getSupportedExtensions
> * getSupportedControls
> * getSupportedFeatures
> Do they return the OIDs, or a name, or a description (what language)? 
> The implementation 
> org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
> for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.