You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jo...@apache.org on 2015/10/14 14:30:57 UTC
[3/6] mesos git commit: CMake:[2/3] Prepared process library tests to
run with `make check`.
CMake:[2/3] Prepared process library tests to run with `make check`.
Right now running the Mesos tests from the default tests target will (1)
aggregate all our tests into a semi-useless report that hides all the
errors, and (2) strip all our colors when you do pass the verbosity flag
to get rid of the "report" structure.
This commit will prepare us to run the tests with with color, without
this default reporting structure. We do this by moving the tests target
to a `CACHE STRING` which can be referenced by the tests.
Review: https://reviews.apache.org/r/39092
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/8db18591
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/8db18591
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/8db18591
Branch: refs/heads/master
Commit: 8db18591877c9a722a419fd2f413dcdd4c149eab
Parents: f4636a7
Author: Alex Clemmer <cl...@gmail.com>
Authored: Wed Oct 14 14:01:27 2015 +0200
Committer: Joris Van Remoortere <jo...@gmail.com>
Committed: Wed Oct 14 14:29:56 2015 +0200
----------------------------------------------------------------------
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake | 4 ++++
3rdparty/libprocess/src/tests/CMakeLists.txt | 2 --
2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/8db18591/3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake b/3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
index ea6db09..d60bce2 100644
--- a/3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
+++ b/3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
@@ -31,6 +31,10 @@
# dependencies (e.g., where to find the .so/.dll files) without having to also
# export the variables for the dependencies that only the test package has.
+set(
+ PROCESS_TESTS_TARGET process_tests
+ CACHE STRING "Target we use to refer to tests for the process library")
+
# DIRECTORY STRUCTURE FOR THIRD-PARTY LIBS REQUIRED FOR TEST INFRASTRUCTURE.
############################################################################
EXTERNAL("gmock" ${GMOCK_VERSION} "${PROCESS_3RD_BIN}")
http://git-wip-us.apache.org/repos/asf/mesos/blob/8db18591/3rdparty/libprocess/src/tests/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/tests/CMakeLists.txt b/3rdparty/libprocess/src/tests/CMakeLists.txt
index a14b5b8..99c9754 100644
--- a/3rdparty/libprocess/src/tests/CMakeLists.txt
+++ b/3rdparty/libprocess/src/tests/CMakeLists.txt
@@ -14,8 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-set(PROCESS_TESTS_TARGET process_tests)
-
# PROCESS TESTS.
################
set(PROCESS_TESTS_SRC