[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #545: Yet more Akka version numbers in deprecation warnings

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #545:
URL: https://github.com/apache/incubator-pekko/pull/545#discussion_r1285258848


##########
cluster/src/test/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializerSpec.scala:
##########
@@ -131,7 +131,7 @@ class ClusterMessageSerializerSpec extends PekkoSpec("pekko.actor.provider = clu
       checkSerialization(InternalClusterAction.Welcome(uniqueAddress, g2))
     }
 
-    // can be removed in 2.6.3 only checks deserialization with new not yet in effect manifests for 2.6.2
+    // can be removed in Akka 2.6.3 only checks deserialization with new not yet in effect manifests for Akka 2.6.2

Review Comment:
   My preference is to start by making the confusing version numbers explicit. There will be arguments about what Pekko versions will be the ones where we can remove code. There is an incomplete discussion on the mailing list. When we start making some decisions, we can go back into the code and replace the Akka versions with the agreed Pekko versions.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org