You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/08/17 17:41:25 UTC

Review Request 51188: GEODE-1776: Always read all of the results in ExecuteRegionFunctionOp

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51188/
-----------------------------------------------------------

Review request for geode and Barry Oglesby.


Repository: geode


Description
-------

Read all of the results from the wire in
ExecuteRegionFunctionOp.processResponse, even if we read an exception as
one of the responses. This ensures that all data is read off the wire.


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ExecuteFunctionOp.java 278f1f79afa98823df27974da2907685c7e5e641 
  geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ExecuteRegionFunctionOp.java d1540204546604ff7ed3d3d490ac40d079ac2953 
  geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ExecuteRegionFunctionSingleHopOp.java ce7c3f84092f59051e5a148a42cc6f06adc787fe 

Diff: https://reviews.apache.org/r/51188/diff/


Testing
-------


Thanks,

Dan Smith


Re: Review Request 51188: GEODE-1776: Always read all of the results in ExecuteRegionFunctionOp

Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51188/#review146033
-----------------------------------------------------------


Ship it!




Ship It!

- Barry Oglesby


On Aug. 17, 2016, 5:41 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51188/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2016, 5:41 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Read all of the results from the wire in
> ExecuteRegionFunctionOp.processResponse, even if we read an exception as
> one of the responses. This ensures that all data is read off the wire.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ExecuteFunctionOp.java 278f1f79afa98823df27974da2907685c7e5e641 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ExecuteRegionFunctionOp.java d1540204546604ff7ed3d3d490ac40d079ac2953 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ExecuteRegionFunctionSingleHopOp.java ce7c3f84092f59051e5a148a42cc6f06adc787fe 
> 
> Diff: https://reviews.apache.org/r/51188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>