[GitHub] [netbeans] neilcsmith-net commented on issue #2097: [NETBEANS-4206] Only set project location once directly from PROJECT_…

[GitBox <gi...@apache.org>]

neilcsmith-net commented on issue #2097:
URL: https://github.com/apache/netbeans/pull/2097#issuecomment-617840353


   > I can probably find it again. Here's an easy way to see it. In store() set "projdir"/PROJECT_PARENT_FOLDER property to the same value as picked up in read(), "/tmp/parent" in the example. Then after "Finish" and project creation, there is a "/tmp/parent/src" and the parent project is marked with "unloadable"
   
   Yes, not entirely surprising - something is relying on the incorrect (as documented) value.  That is where the fix should be IMO.  Also, are the `PROJECT_PARENT_FOLDER` and the target folder meant to be the same?  I _think_ both are meant to be the parent folder of the created project?
   
   Maybe can be fixed up as part of the wizard instantiate?
   
   Personally, given that the prev/next bug fix introduced something worse, I'd still rather revert and review post 12.0 than risk adding to it and leaving a problem in there. But see what others think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists