You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/12/08 09:57:00 UTC
[jira] [Commented] (MCHECKSTYLE-385) Violation should be a value
class
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245783#comment-17245783 ]
Hudson commented on MCHECKSTYLE-385:
------------------------------------
Build succeeded in Jenkins: Maven » Maven TLP » maven-checkstyle-plugin » master #23
See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-checkstyle-plugin/job/master/23/
> Violation should be a value class
> ---------------------------------
>
> Key: MCHECKSTYLE-385
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-385
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
> Affects Versions: 3.1.0
> Environment: Any (Linux, Window OS, etc.)
> Reporter: Benjamin Marwell
> Priority: Minor
> Labels: easyfix, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Dear developers,
> while starting to implement the feature https://issues.apache.org/jira/browse/MCHECKSTYLE-356, I found out that a refactoring is needed.
>
> The method {color:#403294}{{int countViolations(Parser)}}{color} does so many things besides counting violations. Some of them are:
> * checking, if printing violations is wanted.
> * actually printing violations
> * counting violations
> * counting ignored violations
> * checking ignored violations count > 0 and logging
> * Keeping track of file changes
> I would like to rework this part of the code with no functional changes by creating a "Violation" value class.
> PR follows.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)