[jira] [Comment Edited] (IGNITE-10740) Add documentation for IGNITE_DISABLE_TRIGGERING_CACHE_INTERCEPTOR_ON_CONFLICT

["Artem Budnikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748480#comment-16748480 ] 

Artem Budnikov edited comment on IGNITE-10740 at 1/22/19 8:11 AM:
------------------------------------------------------------------

The behaviour this option enables should be the default behaviour and the option should be removed (it shouldn't have been added in the first place). Anyway, if it needs to be documented it should be documented in the javadoc for interceptors or other interfaces where it is relevant. That's the most appropriate place for it. Also, if the behaviour of non-idempotent interceptors is different from that of idempotent ones, this should also be documented in the javadoc.

See also: https://issues.apache.org/jira/browse/IGNITE-10984


was (Author: artem budnikov):
The behaviour this option enables should be the default behaviour and the option should be removed (it shouldn't have been added in the first place). Anyway, if it needs to be documented it should be documented in the javadoc for interceptors or other interfaces where it is relevant. That's the most appropriate place for it. Also, if the behaviour of non-idempotent interceptors is different from idempotent ones, this should also be documented in the javadoc.

See also: https://issues.apache.org/jira/browse/IGNITE-10984

> Add documentation for IGNITE_DISABLE_TRIGGERING_CACHE_INTERCEPTOR_ON_CONFLICT
> -----------------------------------------------------------------------------
>
>                 Key: IGNITE-10740
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10740
>             Project: Ignite
>          Issue Type: Task
>          Components: documentation
>            Reporter: Sergey Antonov
>            Assignee: Artem Budnikov
>            Priority: Major
>             Fix For: 2.8
>
>
> We should add to documentation IGNITE_DISABLE_TRIGGERING_CACHE_INTERCEPTOR_ON_CONFLICT option.
> As a reference you could get javadoc from skipInterceptor() :
> {{Checks, that cache interceptor should be skipped. It is expects by default behavior that Interceptor methods (\{@link CacheInterceptor#onBeforePut(Cache.Entry, Object)}, \{@link CacheInterceptor#onAfterPut(Cache.Entry)}, \{@link CacheInterceptor#onBeforeRemove(Cache.Entry)} and \{@link CacheInterceptor#onAfterRemove(Cache.Entry)}) will be called, but \{@link CacheInterceptor#onGet(Object, Object)}. This can even make DR-update flow broken in case of non-idempotent Interceptor and force users to call onGet manually as the only workaround. Also, user may want to skip Interceptor to avoid redundant entry transformation for DR updates and exchange with internal data b/w data centres which is a normal case.}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)