You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/30 06:11:27 UTC

[GitHub] [arrow] kou commented on a diff in pull request #13244: ARROW-12626: [C++] Support toolchain xsimd, update toolchain version to version 8.1.0

kou commented on code in PR #13244:
URL: https://github.com/apache/arrow/pull/13244#discussion_r884450011


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2231,16 +2231,24 @@ if((NOT ARROW_SIMD_LEVEL STREQUAL "NONE") OR (NOT ARROW_RUNTIME_SIMD_LEVEL STREQ
 else()
   set(ARROW_USE_XSIMD FALSE)
 endif()
+
+set(ARROW_XSIMD_REQUIRED_VERSION "8.1.0")
+
 if(ARROW_USE_XSIMD)
-  set(xsimd_SOURCE "BUNDLED")
-  resolve_dependency(xsimd)
+  # Distros don't always provide up to date xsimd packages
+  set(xsimd_SOURCE "AUTO")

Review Comment:
   Can we remove this because `xsimd_SOURCE` is `AUTO` by default?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org