You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2016/04/22 22:18:36 UTC
svn commit: r1740601 [12/15] - /myfaces/site/publish/tobago/
Modified: myfaces/site/publish/tobago/pmd.html
URL: http://svn.apache.org/viewvc/myfaces/site/publish/tobago/pmd.html?rev=1740601&r1=1740600&r2=1740601&view=diff
==============================================================================
--- myfaces/site/publish/tobago/pmd.html (original)
+++ myfaces/site/publish/tobago/pmd.html Fri Apr 22 20:18:21 2016
@@ -1,7 +1,7 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
- <title>Tobago - PMD Results</title>
+ <title>Tobago – PMD Results</title>
<link rel="stylesheet" type="text/css" media="all" href="./css/maven-base.css"/>
<link rel="stylesheet" type="text/css" media="all" href="./css/maven-theme.css"/>
<link rel="stylesheet" type="text/css" media="print" href="./css/print.css"/>
@@ -14,7 +14,7 @@
<div class="date">
- Last Published: 02 Feb 2016
+ Last Published: 22 Apr 2016
</div>
<ul>
<li>
@@ -193,7 +193,7 @@
</li>
<li class="none">
- <a href="dev-activity.html">Developer Activity</a>
+ <a href="changelog.html">Change Log</a>
</li>
<li class="none">
@@ -201,7 +201,7 @@
</li>
<li class="none">
- <a href="changelog.html">Change Log</a>
+ <a href="dev-activity.html">Developer Activity</a>
</li>
<li class="none">
@@ -255,98 +255,90 @@
<img alt="Built by Maven" src="./img/banners/maven-feather.png"></img>
</a>
</div> <!-- close powered_by -->
+ <div id="powered_by">
+ <a href="http://www.apache.org/events/current-event.html" title="ApacheCon">
+ <img alt="ApacheCon" src="http://www.apache.org/events/current-event-125x125.png"/>
+ </a>
+ </div>
<div class="clear"></div>
</div>
<div id="body_column">
<div>
<div class="section">
- <h2>PMD Results<a name="PMD_Results"></a></h2>
+ <h2><a name="PMD_Results"></a>PMD Results</h2>
<p>The following document contains the results of <a class="externalLink"
href="http://pmd.sourceforge.net/">PMD</a> 5.2.3.</p></div>
<div class="section">
- <h2>Files<a name="Files"></a></h2>
+ <h2><a name="Files"></a>Files</h2>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/application/ActionListenerImpl.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoapplicationActionListenerImpl.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocompatFacesUtilsEL.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/compat/FacesUtilsEL.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Private field 'base' could be made final; it is only initialized in the declaration or constructor.
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L45">45</a></td>
+ <td>This class has too many methods, consider refactoring it.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L48">48</a>–<a
+ href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L268">268</a></td>
</tr>
<tr class="a">
- <td>An instanceof check is being performed on the caught exception. Create a separate catch clause for
- this exception type.
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L57">57</a></td>
+ <td>These nested if statements could be combined</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L72">72</a>–<a
+ href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L74">74</a></td>
</tr>
<tr class="b">
- <td>Local variable 'errorLogMsg' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L67">67</a></td>
- </tr>
- <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L68">68</a>–<a
- href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L74">74</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L206">206</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L82">82</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L216">216</a>–<a
+ href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L221">221</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/compat/FacesUtilsEL.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocompatFacesUtilsEL.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentAttributes.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/component/Attributes.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
- <td>This class has too many methods, consider refactoring it.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L48">48</a>–<a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L268">268</a></td>
- </tr>
<tr class="a">
- <td>These nested if statements could be combined</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L72">72</a>–<a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L74">74</a></td>
+ <td>Parameter 'explicit' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L267">267</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L206">206</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L272">272</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L276">276</a></td>
</tr>
<tr class="a">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L216">216</a>–<a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L221">221</a></td>
+ <td>Parameter 'name' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L279">279</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/Facets.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentFacets.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentLabelLayout.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/component/LabelLayout.java</h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="a">
- <td>Fields should be declared at the top of the class, before any method declarations, constructors,
- initializers or inner classes.
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L55">55</a></td>
+ <td>Parameter 'facesContext' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/LabelLayout.html#L88">88</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodBindingToMethodExpression.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodBindingToMethodExpression.java"></a>Tobago
+ Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java</h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
@@ -355,7 +347,7 @@
<tr class="a">
<td>This class has too many methods, consider refactoring it.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L37">37</a>–<a
- href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L231">231</a>
+ href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L241">241</a>
</td>
</tr>
<tr class="b">
@@ -365,14 +357,14 @@
</tr>
<tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L93">93</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L96">96</a>
</td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodExpressionToMethodBinding.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodExpressionToMethodBinding.java"></a>Tobago
+ Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java</h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
@@ -387,26 +379,26 @@
<td>Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing
import 'javax.faces.el.MethodNotFoundException'
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L62">62</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L63">63</a>
</td>
</tr>
<tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L68">68</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L70">70</a>
</td>
</tr>
<tr class="b">
<td>Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing
import 'javax.faces.el.MethodNotFoundException'
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L74">74</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L76">76</a>
</td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/Sorter.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentSorter.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentSorter.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/component/Sorter.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -433,27 +425,27 @@
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
<tr class="b">
- <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
+ <td>The method perform() has an NPath complexity of 139872</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>Avoid really long methods.</td>
+ <td>The method 'perform' has a Modified Cyclomatic Complexity of 28.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="b">
- <td>The method 'perform' has a Modified Cyclomatic Complexity of 28.</td>
+ <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>The method 'perform' has a Standard Cyclomatic Complexity of 28.</td>
+ <td>Avoid really long methods.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="b">
- <td>The method perform() has an NPath complexity of 139872</td>
+ <td>The method 'perform' has a Standard Cyclomatic Complexity of 28.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
@@ -479,8 +471,8 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/SupportsRenderedPartially.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentSupportsRenderedPartially.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentSupportsRenderedPartially.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/component/SupportsRenderedPartially.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -493,8 +485,8 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/ClientProperties.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextClientProperties.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextClientProperties.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/ClientProperties.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -502,13 +494,13 @@
</tr>
<tr class="b">
<td>Use equals() to compare object references.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#L204">204</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#L133">133</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/Markup.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextMarkup.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextMarkup.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/Markup.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -516,48 +508,48 @@
</tr>
<tr class="b">
<td>This class has too many methods, consider refactoring it.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L50">50</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L317">317</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L328">328</a></td>
</tr>
<tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L96">96</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L106">106</a></td>
</tr>
<tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L106">106</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L116">116</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L166">166</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L176">176</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L178">178</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L188">188</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L179">179</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L189">189</a></td>
</tr>
<tr class="b">
<td>Use equals() to compare object references.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L201">201</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L212">212</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L204">204</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L215">215</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L215">215</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L226">226</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L245">245</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L254">254</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L256">256</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L265">265</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextMarkupConfig.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextMarkupConfig.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/MarkupConfig.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -572,132 +564,224 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/ResourceManagerUtils.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextResourceManagerUtils.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextResourceManagerUtils.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/ResourceManagerUtils.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L154">154</a></td>
- </tr>
- <tr class="a">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L166">166</a></td>
- </tr>
- <tr class="b">
<td>This call to String.startsWith can be rewritten using String.charAt(0)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L233">233</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L184">184</a></td>
</tr>
<tr class="a">
<td>Local variable 'dot' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L243">243</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L194">194</a></td>
</tr>
<tr class="b">
<td>Local variable 'slash' could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L247">247</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L198">198</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextThemeImpl.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextThemeImpl.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/ThemeImpl.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Possible God class (WMC=51, ATFD=16, TCC=0.06436781609195402)</td>
+ <td>Possible God class (WMC=60, ATFD=16, TCC=0.07816091954022988)</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L20">20</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L276">276</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
+ </tr>
+ <tr class="a">
+ <td>The class 'ThemeImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 12).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
+ </tr>
+ <tr class="b">
+ <td>The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 12).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
</tr>
<tr class="a">
<td>Too many fields</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L276">276</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
</tr>
<tr class="b">
+ <td>The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 12).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L314">314</a></td>
+ </tr>
+ <tr class="a">
<td>Private field 'productionResources' could be made final; it is only initialized in the declaration or
constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L46">46</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'resources' could be made final; it is only initialized in the declaration or
constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L47">47</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'unmodifiable'</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L55">55</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Deeply nested if..then statements are hard to read</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L151">151</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L156">156</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L154">154</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L159">159</a></td>
+ </tr>
+ <tr class="a">
+ <td>The method 'toString' has a Cyclomatic Complexity of 12.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L273">273</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L313">313</a></td>
+ </tr>
+ <tr class="b">
+ <td>The method 'toString' has a Standard Cyclomatic Complexity of 12.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L273">273</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L313">313</a></td>
+ </tr>
+ <tr class="a">
+ <td>The method 'toString' has a Modified Cyclomatic Complexity of 12.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L273">273</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L313">313</a></td>
+ </tr>
+ <tr class="b">
+ <td>StringBuffer constructor is initialized with size 16, but has at least 112 characters appended.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L274">274</a></td>
+ </tr>
+ <tr class="a">
+ <td>StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L275">275</a></td>
</tr>
<tr class="b">
<td>StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L180">180</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L276">276</a></td>
+ </tr>
+ <tr class="a">
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L278">278</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L284">284</a></td>
+ </tr>
+ <tr class="b">
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L279">279</a></td>
+ </tr>
+ <tr class="a">
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L281">281</a></td>
+ </tr>
+ <tr class="b">
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L286">286</a></td>
+ </tr>
+ <tr class="a">
+ <td>Local variable 's' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L286">286</a></td>
+ </tr>
+ <tr class="b">
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L287">287</a></td>
+ </tr>
+ <tr class="a">
+ <td>Local variable 's' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L291">291</a></td>
+ </tr>
+ <tr class="b">
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L291">291</a></td>
+ </tr>
+ <tr class="a">
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L292">292</a></td>
+ </tr>
+ <tr class="b">
+ <td>Local variable 's' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L296">296</a></td>
+ </tr>
+ <tr class="a">
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L296">296</a></td>
+ </tr>
+ <tr class="b">
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L297">297</a></td>
+ </tr>
+ <tr class="a">
+ <td>Local variable 's' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L301">301</a></td>
+ </tr>
+ <tr class="b">
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L301">301</a></td>
</tr>
<tr class="a">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L183">183</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L302">302</a></td>
</tr>
<tr class="b">
<td>Avoid appending characters as strings in StringBuffer.append.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L186">186</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L306">306</a></td>
+ </tr>
+ <tr class="a">
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L309">309</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResource.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResource.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/ThemeResource.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResource.html#L50">50</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResource.html#L56">56</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/ThemeResources.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResources.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResources.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/ThemeResources.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
+ <tr class="b">
+ <td>Parameter 'production' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L39">39</a></td>
+ </tr>
<tr class="a">
- <td>Private field 'scriptList' could be made final; it is only initialized in the declaration or
- constructor.
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L34">34</a></td>
+ <td>Parameter 'exclude' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L67">67</a></td>
</tr>
<tr class="b">
- <td>Private field 'styleList' could be made final; it is only initialized in the declaration or
- constructor.
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L35">35</a></td>
+ <td>Parameter 'exclude' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L71">71</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextTobagoBundle.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextTobagoBundle.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/TobagoBundle.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -712,8 +796,8 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextTransientStateHolder.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextTransientStateHolder.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/TransientStateHolder.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -727,27 +811,27 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextUserAgent.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextUserAgent.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/context/UserAgent.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>The class 'UserAgent' has a Standard Cyclomatic Complexity of 3 (Highest = 19).</td>
+ <td>The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L386">386</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
<tr class="a">
- <td>The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19).</td>
+ <td>The class 'UserAgent' has a Standard Cyclomatic Complexity of 3 (Highest = 19).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L386">386</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
<tr class="b">
- <td>The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20).</td>
+ <td>The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L386">386</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
<tr class="a">
<td>The String literal "msie" appears 12 times in this file; the first occurrence is on line
@@ -774,111 +858,126 @@
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L154">154</a></td>
</tr>
<tr class="a">
- <td>The method 'getInstance' has a Standard Cyclomatic Complexity of 19.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L275">275</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L330">330</a></td>
+ <td>The method 'getInstance' has a Modified Cyclomatic Complexity of 19.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L279">279</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L334">334</a></td>
</tr>
<tr class="b">
- <td>The method 'getInstance' has a Cyclomatic Complexity of 20.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L275">275</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L330">330</a></td>
+ <td>The method 'getInstance' has a Standard Cyclomatic Complexity of 19.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L279">279</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L334">334</a></td>
</tr>
<tr class="a">
- <td>The method 'getInstance' has a Modified Cyclomatic Complexity of 19.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L275">275</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L330">330</a></td>
+ <td>The method 'getInstance' has a Cyclomatic Complexity of 20.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L279">279</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L334">334</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L346">346</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L348">348</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L350">350</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L352">352</a></td>
</tr>
<tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L360">360</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L364">364</a></td>
</tr>
<tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L378">378</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L382">382</a></td>
+ </tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoconvertDurationConverter.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/convert/DurationConverter.java</h3>
+ <table border="0" class="bodyTable">
+ <tr class="a">
+ <th>Violation</th>
+ <th>Line</th>
+ </tr>
+ <tr class="b">
+ <td>Unnecessary wrapper object creation</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L65">65</a></td>
+ </tr>
+ <tr class="a">
+ <td>Avoid declaring a variable if it is unreferenced before a possible exit point.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L89">89</a></td>
+ </tr>
+ <tr class="b">
+ <td>The default label should be the last label in a switch statement</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L129">129</a>–<a
+ href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L145">145</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoconvertDurationConverter.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoelConstantMethodExpression.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/el/ConstantMethodExpression.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>The class 'DurationConverter' has a Modified Cyclomatic Complexity of 7 (Highest = 10).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L37">37</a>–<a
- href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L150">150</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L35">35</a>–<a
+ href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L36">36</a></td>
</tr>
<tr class="a">
- <td>The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L37">37</a>–<a
- href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L150">150</a></td>
+ <td>Parameter 'outcome' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L38">38</a></td>
</tr>
<tr class="b">
- <td>The class 'DurationConverter' has a Standard Cyclomatic Complexity of 8 (Highest = 10).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L37">37</a>–<a
- href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L150">150</a></td>
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L43">43</a></td>
</tr>
<tr class="a">
- <td>Unnecessary wrapper object creation</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L67">67</a></td>
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
</tr>
<tr class="b">
- <td>Avoid declaring a variable if it is unreferenced before a possible exit point.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L90">90</a></td>
+ <td>Parameter 'params' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
</tr>
<tr class="a">
- <td>The method 'getUnitFactor' has a Cyclomatic Complexity of 10.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L121">121</a>–<a
- href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L148">148</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
</tr>
<tr class="b">
- <td>The method 'getUnitFactor' has a Modified Cyclomatic Complexity of 10.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L121">121</a>–<a
- href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L148">148</a></td>
+ <td>Parameter 'o' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L55">55</a></td>
</tr>
<tr class="a">
- <td>The method 'getUnitFactor' has a Standard Cyclomatic Complexity of 10.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L121">121</a>–<a
- href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L148">148</a></td>
+ <td>Local variable 'that' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L63">63</a></td>
</tr>
- </table>
- </div>
- <div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodBinding.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoelConstantMethodBinding.java"></a></h3>
- <table border="0" class="bodyTable">
<tr class="b">
- <th>Violation</th>
- <th>Line</th>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L65">65</a></td>
</tr>
<tr class="a">
- <td>Document empty constructor</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodBinding.html#L38">38</a>–<a
- href="./xref/org/apache/myfaces/tobago/el/ConstantMethodBinding.html#L39">39</a></td>
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L85">85</a></td>
</tr>
<tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodBinding.html#L41">41</a></td>
+ <td>Parameter 'state' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
+ </tr>
+ <tr class="a">
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoelUserWrapper.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoelUserWrapper.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/el/UserWrapper.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'roles' could be made final; it is only initialized in the declaration or constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/UserWrapper.html#L35">35</a></td>
@@ -886,14 +985,14 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventFacesEventWrapper.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventFacesEventWrapper.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/FacesEventWrapper.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -902,19 +1001,19 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionStateChangeListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionStateChangeListener.java"></a>Tobago
+ Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L33">33</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L36">36</a></td>
@@ -922,19 +1021,19 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTabChangeListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTabChangeListener.java"></a>Tobago Core
+ - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L33">33</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L36">36</a></td>
@@ -942,91 +1041,66 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeExpansionListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeExpansionListener.java"></a>Tobago
+ Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L34">34</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L36">36</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L37">37</a>
</td>
</tr>
- <tr class="b">
- <td>Avoid unused private methods such as 'elContext()'.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L47">47</a>
- </td>
- </tr>
- </table>
- </div>
- <div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeMarkedListener.java"></a></h3>
- <table border="0" class="bodyTable">
- <tr class="a">
- <th>Violation</th>
- <th>Line</th>
- </tr>
- <tr class="b">
- <td>Avoid using redundant field initializer for 'isTransient'</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L37">37</a>
- </td>
- </tr>
<tr class="a">
- <td>Document empty constructor</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L39">39</a>–<a
- href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L40">40</a></td>
- </tr>
- <tr class="b">
<td>Avoid unused private methods such as 'elContext()'.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L50">50</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L48">48</a>
</td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeSelectedListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeSelectedListener.java"></a>Tobago
+ Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L33">33</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L36">36</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid unused private methods such as 'elContext()'.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L46">46</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L47">47</a>
</td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/PageAction.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventPageAction.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventPageAction.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/PageAction.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/PageAction.html#L85">85</a>–<a
href="./xref/org/apache/myfaces/tobago/event/PageAction.html#L89">89</a></td>
@@ -1034,14 +1108,14 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventPageActionEvent.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventPageActionEvent.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/PageActionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'action' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1050,14 +1124,14 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/PopupActionListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventPopupActionListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventPopupActionListener.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/PopupActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/PopupActionListener.html#L37">37</a>–<a
href="./xref/org/apache/myfaces/tobago/event/PopupActionListener.html#L38">38</a></td>
@@ -1065,48 +1139,48 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/PopupFacetActionListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventPopupFacetActionListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventPopupFacetActionListener.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/PopupFacetActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/PopupFacetActionListener.html#L40">40</a>–<a
- href="./xref/org/apache/myfaces/tobago/event/PopupFacetActionListener.html#L46">46</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/PopupFacetActionListener.html#L41">41</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/PopupFacetActionListener.html#L47">47</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventResetInputActionListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventResetInputActionListener.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/ResetInputActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L34">34</a>–<a
href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L35">35</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L37">37</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventSortActionEvent.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventSortActionEvent.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/SortActionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'column' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1115,20 +1189,20 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventTreeExpansionEvent.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventTreeExpansionEvent.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/TreeExpansionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'oldExpanded' could be made final; it is only initialized in the declaration or
constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/TreeExpansionEvent.html#L30">30</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'newExpanded' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1137,30 +1211,8 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/TreeMarkedEvent.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventTreeMarkedEvent.java"></a></h3>
- <table border="0" class="bodyTable">
- <tr class="a">
- <th>Violation</th>
- <th>Line</th>
- </tr>
- <tr class="b">
- <td>Private field 'oldMarked' could be made final; it is only initialized in the declaration or
- constructor.
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/TreeMarkedEvent.html#L34">34</a></td>
- </tr>
- <tr class="a">
- <td>Private field 'newMarked' could be made final; it is only initialized in the declaration or
- constructor.
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/TreeMarkedEvent.html#L35">35</a></td>
- </tr>
- </table>
- </div>
- <div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/TreeSelectedEvent.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventTreeSelectedEvent.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventTreeSelectedEvent.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/TreeSelectedEvent.java</h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
@@ -1181,8 +1233,8 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionPopupActionListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionPopupActionListener.java"></a>Tobago Core
+ - org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -1196,8 +1248,8 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionResetInputActionListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionResetInputActionListener.java"></a>Tobago
+ Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -1213,8 +1265,8 @@
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionSheetStateChangeListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionSheetStateChangeListener.java"></a>Tobago
+ Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -1230,21 +1282,21 @@
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a
- href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L47">47</a>–<a
- href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L51">51</a>
+ href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L48">48</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L52">52</a>
</td>
</tr>
<tr class="b">
<td>No need to check for null before an instanceof</td>
<td><a
- href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L80">80</a>
+ href="./xref/org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.html#L85">85</a>
</td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionTabChangeListener.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventValueExpressionTabChangeListener.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -1257,18 +1309,18 @@
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L47">47</a>–<a
- href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L51">51</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L48">48</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L52">52</a></td>
</tr>
<tr class="b">
<td>No need to check for null before an instanceof</td>
- <td><a href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L80">80</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.html#L85">85</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/facelets/AttributeHandler.java<a
- name="Tobago_Core_-_orgapachemyfacestobagofaceletsAttributeHandler.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsAttributeHandler.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/facelets/AttributeHandler.java</h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
@@ -1277,87 +1329,87 @@
<tr class="b">
<td>A high number of imports can indicate a high degree of coupling within an object.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L20">20</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L366">366</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
</tr>
<tr class="a">
- <td>Possible God class (WMC=79, ATFD=79, TCC=0.027777777777777776)</td>
+ <td>Possible God class (WMC=78, ATFD=88, TCC=0.027777777777777776)</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L20">20</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L366">366</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
</tr>
<tr class="b">
- <td>The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 59).</td>
+ <td>The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 58).</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L366">366</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
</tr>
<tr class="a">
- <td>The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 52).</td>
+ <td>The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 51).</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L366">366</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
</tr>
<tr class="b">
- <td>The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 52).</td>
+ <td>The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 51).</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L366">366</a></td>
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L361">361</a></td>
</tr>
<tr class="a">
- <td>The method apply() has an NCSS line count of 165</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L73">73</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L283">283</a></td>
+ <td>Avoid really long methods.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
</tr>
<tr class="b">
- <td>The method 'apply' has a Standard Cyclomatic Complexity of 52.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L73">73</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L283">283</a></td>
+ <td>The method 'apply' has a Modified Cyclomatic Complexity of 51.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
</tr>
<tr class="a">
- <td>Avoid really long methods.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L73">73</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L283">283</a></td>
+ <td>The method 'apply' has a Standard Cyclomatic Complexity of 51.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
</tr>
<tr class="b">
- <td>The method 'apply' has a Cyclomatic Complexity of 59.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L73">73</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L283">283</a></td>
+ <td>The method apply() has an NCSS line count of 162</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
</tr>
<tr class="a">
- <td>The method 'apply' has a Modified Cyclomatic Complexity of 52.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L73">73</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L283">283</a></td>
+ <td>The method 'apply' has a Cyclomatic Complexity of 58.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L278">278</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L80">80</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L281">281</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L81">81</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L276">276</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L84">84</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L102">102</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L85">85</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L103">103</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L107">107</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L125">125</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L108">108</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L126">126</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L193">193</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L200">200</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L194">194</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L201">201</a></td>
</tr>
<tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L307">307</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L302">302</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L313">313</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L319">319</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L308">308</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L314">314</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/facelets/ConverterHandler.java<a
- name="Tobago_Core_-_orgapachemyfacestobagofaceletsConverterHandler.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsConverterHandler.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/facelets/ConverterHandler.java</h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
@@ -1365,22 +1417,22 @@
</tr>
<tr class="a">
<td>Avoid declaring a variable if it is unreferenced before a possible exit point.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L53">53</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L54">54</a></td>
</tr>
<tr class="b">
<td>New exception is thrown in catch block, original stack trace may be lost</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L65">65</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L66">66</a></td>
</tr>
<tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L67">67</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L69">69</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L68">68</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/ConverterHandler.html#L70">70</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java<a
- name="Tobago_Core_-_orgapachemyfacestobagofaceletsFixCharacterEncodingFilter.java"></a></h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsFixCharacterEncodingFilter.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java</h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
@@ -1388,245 +1440,32 @@
</tr>
<tr class="a">
<td>Document empty method</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L31">31</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L33">33</a></td>
- </tr>
- <tr class="b">
- <td>Document empty method</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L44">44</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L45">45</a></td>
- </tr>
- </table>
- </div>
- <div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/facelets/FlowLayoutRule.java<a
- name="Tobago_Core_-_orgapachemyfacestobagofaceletsFlowLayoutRule.java"></a></h3>
- <table border="0" class="bodyTable">
- <tr class="a">
- <th>Violation</th>
- <th>Line</th>
- </tr>
- <tr class="b">
- <td>The class 'FlowLayoutRule' has a Standard Cyclomatic Complexity of 10 (Highest = 9).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L140">140</a></td>
- </tr>
- <tr class="a">
- <td>The class 'FlowLayoutRule' has a Cyclomatic Complexity of 10 (Highest = 9).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L140">140</a></td>
- </tr>
- <tr class="b">
- <td>The class 'FlowLayoutRule' has a Modified Cyclomatic Complexity of 10 (Highest = 9).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L33">33</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L140">140</a></td>
- </tr>
- <tr class="a">
- <td>These nested if statements could be combined</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L39">39</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L58">58</a></td>
- </tr>
- <tr class="b">
- <td>Deeply nested if..then statements are hard to read</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L40">40</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L42">42</a></td>
- </tr>
- <tr class="a">
- <td>Deeply nested if..then statements are hard to read</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L43">43</a>–<a
- href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L45">45</a></td>
- </tr>
- <tr class="b">
- <td>Deeply nested if..then statements are hard to read</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/FlowLayoutRule.html#L46">46</a>–<a
[... 27731 lines stripped ...]