You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/09 20:32:04 UTC

[GitHub] KellenSunderland commented on a change in pull request #9330: Add clang job to the CI

KellenSunderland commented on a change in pull request #9330: Add clang job to the CI
URL: https://github.com/apache/incubator-mxnet/pull/9330#discussion_r160516953
 
 

 ##########
 File path: Jenkinsfile
 ##########
 @@ -168,6 +168,24 @@ try {
         }
       }
     },
+    'CPU: Clang': {
+      node('mxnetlinux-cpu') {
+        ws('workspace/build-cpu-clang') {
+          init_git()
+          def flag = """ \
+            USE_PROFILER=1                \
+            USE_CPP_PACKAGE=1             \
+            USE_BLAS=openblas             \
+            USE_OPENMP=0                  \
 
 Review comment:
   Yes, correct about disabling USE_OPENMP.  The goal of this job is to protect against accidental broken builds on OSX by using a similar build chain and flags on linux.
   
   I think you do have a good point though, I can pretty easily create another job with a modern clang that has USE_OPENMP turned on.  IMO the extra environment would be valuable to test, and shouldn't use too many resources relative to other CI jobs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services