You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/04/29 01:33:11 UTC
Review Request 33647: Only log processes in the slave cgroup on
recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33647/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, and Timothy Chen.
Bugs: MESOS-2668
https://issues.apache.org/jira/browse/MESOS-2668
Repository: mesos
Description
-------
Changes previous behavior where the slave would exit if processes were in the slave cgroup.
Diffs
-----
src/slave/slave.cpp c5b4847253990b31fb05dfcd40de0102d18c8024
Diff: https://reviews.apache.org/r/33647/diff/
Testing
-------
None.
Thanks,
Ian Downes
Re: Review Request 33647: Only log processes in the slave cgroup on
recovery.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33647/#review81905
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On April 28, 2015, 11:48 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33647/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 11:48 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2668
> https://issues.apache.org/jira/browse/MESOS-2668
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changes previous behavior where the slave would exit if processes were in the slave cgroup.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp c5b4847253990b31fb05dfcd40de0102d18c8024
>
> Diff: https://reviews.apache.org/r/33647/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 33647: Only log processes in the slave cgroup on
recovery.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33647/
-----------------------------------------------------------
(Updated April 28, 2015, 4:48 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Timothy Chen.
Bugs: MESOS-2668
https://issues.apache.org/jira/browse/MESOS-2668
Repository: mesos
Description
-------
Changes previous behavior where the slave would exit if processes were in the slave cgroup.
Diffs (updated)
-----
src/slave/slave.cpp c5b4847253990b31fb05dfcd40de0102d18c8024
Diff: https://reviews.apache.org/r/33647/diff/
Testing
-------
None.
Thanks,
Ian Downes
Re: Review Request 33647: Only log processes in the slave cgroup on
recovery.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33647/
-----------------------------------------------------------
(Updated April 28, 2015, 4:47 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Timothy Chen.
Bugs: MESOS-2668
https://issues.apache.org/jira/browse/MESOS-2668
Repository: mesos
Description
-------
Changes previous behavior where the slave would exit if processes were in the slave cgroup.
Diffs (updated)
-----
src/slave/slave.cpp c5b4847253990b31fb05dfcd40de0102d18c8024
Diff: https://reviews.apache.org/r/33647/diff/
Testing
-------
None.
Thanks,
Ian Downes
Re: Review Request 33647: Only log processes in the slave cgroup on
recovery.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33647/#review81903
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/33647/#comment132436>
Can you also comment on what the consequence of having those processes left in slave's cgroup? Maybe add a TODO here to address that?
- Jie Yu
On April 28, 2015, 11:33 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33647/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 11:33 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2668
> https://issues.apache.org/jira/browse/MESOS-2668
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changes previous behavior where the slave would exit if processes were in the slave cgroup.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp c5b4847253990b31fb05dfcd40de0102d18c8024
>
> Diff: https://reviews.apache.org/r/33647/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Ian Downes
>
>