You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/02/26 20:43:10 UTC
[Impala-ASF-CR] Bump header size to prevent wrapping
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12596
Change subject: Bump header size to prevent wrapping
......................................................................
Bump header size to prevent wrapping
Before this change the header would wrap between the daemon name and the
pages list for the impalad status page.
Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
---
M www/common-header.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/12596/1
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Bump debug web page header size to prevent wrapping
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12596 )
Change subject: Bump debug web page header size to prevent wrapping
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 00:08:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump debug web page header size to prevent wrapping
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12596 )
Change subject: Bump debug web page header size to prevent wrapping
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 19:38:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump debug web page header size to prevent wrapping
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12596 )
Change subject: Bump debug web page header size to prevent wrapping
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 19:53:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump header size to prevent wrapping
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12596 )
Change subject: Bump header size to prevent wrapping
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2258/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 21:04:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump debug web page header size to prevent wrapping
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12596 )
Change subject: Bump debug web page header size to prevent wrapping
......................................................................
Bump debug web page header size to prevent wrapping
Before this change the header would wrap between the daemon name and the
pages list for the impalad debug page.
Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Reviewed-on: http://gerrit.cloudera.org:8080/12596
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M www/common-header.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Bump debug web page header size to prevent wrapping
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12596 )
Change subject: Bump debug web page header size to prevent wrapping
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3844/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 19:53:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump debug web page header size to prevent wrapping
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12596
to look at the new patch set (#2).
Change subject: Bump debug web page header size to prevent wrapping
......................................................................
Bump debug web page header size to prevent wrapping
Before this change the header would wrap between the daemon name and the
pages list for the impalad debug page.
Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
---
M www/common-header.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/12596/2
--
To view, visit http://gerrit.cloudera.org:8080/12596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icc9c97c41ef12016f797101b25a49464de233034
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>