You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/10 05:33:12 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28444: [SPARK-31632][CORE][WEBUI] Make the ApplicationInfo always available when accessed
HyukjinKwon commented on a change in pull request #28444:
URL: https://github.com/apache/spark/pull/28444#discussion_r422588340
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -35,8 +36,24 @@ private[spark] class AppStatusStore(
val store: KVStore,
val listener: Option[AppStatusListener] = None) {
+ /**
+ * This method contains an automatic retry logic and tries to get a valid [[v1.ApplicationInfo]].
Review comment:
`ApplicationInfo` seems a proper class which can properly converted into Java class via `Unidoc` in principal. If it works, let's uses `[[...]]`. If it fails to generate the documentation, let's stick to `` `...` ``.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org