You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/11/09 15:10:15 UTC

[GitHub] activemq-artemis pull request #2425: ARTEMIS-2142 Refactor of Patchfix Serve...

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2425

    ARTEMIS-2142 Refactor of Patchfix ServerJMSMessage

    Refactor ServerJMSMessage so it correctly transposes all JMSX headers
    Push common JMSX mappings for JMS to Message Interface mappings into MessageUtil to avoid duplication in ActiveMQMessage and ServerJMSMessage

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2142-refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2425
    
----
commit ea106c604d81f951d2dfbf729166360ffd3417cc
Author: Michael André Pearce <mi...@...>
Date:   2018-11-09T14:57:20Z

    ARTEMIS-2142 Patch Fix ServerJMSMessage for JMSXGROUPSEQ
    
    This is a patch fix for JMSXGROUPSEQ.

commit 60033594b5719c6a286536111925cd9dc6dce8ca
Author: Michael André Pearce <mi...@...>
Date:   2018-11-09T14:59:58Z

    ARTEMIS-2142 Refactor of Patchfix ServerJMSMessage
    
    Refactor ServerJMSMessage so it correctly transposes all JMSX headers
    Push common JMSX mappings for JMS to Message Interface mappings into MessageUtil to avoid duplication in ActiveMQMessage and ServerJMSMessage

----


---

[GitHub] activemq-artemis issue #2425: ARTEMIS-2142 Refactor of Patchfix ServerJMSMes...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2425
  
    I am a bit confused on how to merge this into 2.6.x. If you want a 2.6.x patch can you pull it yourself?


---

[GitHub] activemq-artemis issue #2425: ARTEMIS-2142 Refactor of Patchfix ServerJMSMes...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2425
  
    The idea is https://github.com/apache/activemq-artemis/pull/2424 was the bare minimum fix path, so it would goto HF, or if you're maintaining some private fork ;) you'd use that, and this PR was a fuller refactor but stays in master. 


---

[GitHub] activemq-artemis issue #2425: ARTEMIS-2142 Refactor of Patchfix ServerJMSMes...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2425
  
    This should be merged AFTER https://github.com/apache/activemq-artemis/pull/2424


---