[GitHub] [spark] HyukjinKwon commented on a change in pull request #26577: [SPARK-29943][SQL] Improve error messages for unsupported data type

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #26577: [SPARK-29943][SQL] Improve error messages for unsupported data type
URL: https://github.com/apache/spark/pull/26577#discussion_r352477880
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -440,8 +440,14 @@ private[hive] class HiveClientImpl(
   private def convertHiveTableToCatalogTable(h: HiveTable): CatalogTable = {
     // Note: Hive separates partition columns and the schema, but for us the
     // partition columns are part of the schema
-    val cols = h.getCols.asScala.map(fromHiveColumn)
-    val partCols = h.getPartCols.asScala.map(fromHiveColumn)
+    val (cols, partCols) = try {
+      (h.getCols.asScala.map(fromHiveColumn),
+        h.getPartCols.asScala.map(fromHiveColumn))
 
 Review comment:
   ``` scala
      val (cols, partCols) = try {
         (h.getCols.asScala.map(fromHiveColumn), h.getPartCols.asScala.map(fromHiveColumn))
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org