You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/03/30 14:25:50 UTC
[GitHub] [avro] subhashb opened a new pull request #1165: AVRO-3093: Stop releasing avro-python3 package
subhashb opened a new pull request #1165:
URL: https://github.com/apache/avro/pull/1165
With the deprecation notice in place for some time, we can stop maintaining and releasing `avro-python3` package along with other SDKs
Closes: https://issues.apache.org/jira/browse/AVRO-3093
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/AVRO-3093
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
**NA**
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
**NA**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1165: AVRO-3093: Stop releasing avro-python3 package
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1165:
URL: https://github.com/apache/avro/pull/1165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1165: AVRO-3093: Stop releasing avro-python3 package
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1165:
URL: https://github.com/apache/avro/pull/1165#issuecomment-810396787
I'm doing a full `./build.sh dist` on my local machine to check all languages interop (using the buster docker image from https://github.com/apache/avro/pull/1155)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] subhashb commented on pull request #1165: AVRO-3093: Stop releasing avro-python3 package
Posted by GitBox <gi...@apache.org>.
subhashb commented on pull request #1165:
URL: https://github.com/apache/avro/pull/1165#issuecomment-810402650
Thank you, @RyanSkraba!
@kojiromike Triggered python interop tests by making a small documentation change in the `lang/py` directory (the PR had to be labeled `python` to trigger tests). All interop tests passed. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba edited a comment on pull request #1165: AVRO-3093: Stop releasing avro-python3 package
Posted by GitBox <gi...@apache.org>.
RyanSkraba edited a comment on pull request #1165:
URL: https://github.com/apache/avro/pull/1165#issuecomment-810433580
:point_up: OK, it looks like this is a bug in the `avro.tool` left over from python2, and we never noticed because the tool hasn't been used for rpc interop tests.
We can merge this and take care of the py2 tool error later, the CI will be fine -- it's probably even a good idea to have a JIRA for *that* problem in case anyone ever runs into it (although I can't imagine how...)
(I created AVRO-3100)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1165: AVRO-3093: Stop releasing avro-python3 package
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1165:
URL: https://github.com/apache/avro/pull/1165#issuecomment-810427040
I can confirm that all file interop tests pass, but the RPC interop tests break :/ I don't think these are taken into account in the GitHub Actions yet, but you can launch them after building the world: `./share/test/interop/bin/test_rpc_interop.sh`
```
+ py_tool rpcsend http://127.0.0.1:45815 share/test/schemas/simple.avpr add -file share/test/interop/rpc/add/onePlusOne/request.avro
+ PYTHONPATH=lang/py
+ python3 -m avro.tool rpcsend http://127.0.0.1:45815 share/test/schemas/simple.avpr add -file share/test/interop/rpc/add/onePlusOne/request.avro
Traceback (most recent call last):
File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/rskraba/avro/lang/py/avro/tool.py", line 166, in <module>
sys.exit(main(sys.argv))
File "/home/rskraba/avro/lang/py/avro/tool.py", line 157, in main
send_message(uri, proto, msg, datum)
File "/home/rskraba/avro/lang/py/avro/tool.py", line 91, in send_message
url_obj = urllib.parse(uri)
TypeError: 'module' object is not callable
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike commented on pull request #1165: AVRO-3093: Stop releasing avro-python3 package
Posted by GitBox <gi...@apache.org>.
kojiromike commented on pull request #1165:
URL: https://github.com/apache/avro/pull/1165#issuecomment-810366170
It's hard to tell from iOS GitHub. Did the interop tests run? Can we do something to explicitly trigger those tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1165: AVRO-3093: Stop releasing avro-python3 package
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1165:
URL: https://github.com/apache/avro/pull/1165#issuecomment-810433580
:point_up: OK, it looks like this is a bug in the `avro.tool` left over from python2, and we never noticed because the tool hasn't been used for rpc interop tests.
We can merge this and take care of the py2 tool error later, the CI will be fine -- it's probably even a good idea to have a JIRA for *that* problem in case anyone ever runs into it (although I can't imagine how...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org