You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/07/22 12:02:06 UTC

[GitHub] carbondata pull request #2536: [CARBONDATA-2766] Added null check on filesta...

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/2536

    [CARBONDATA-2766] Added null check on filestatus

    **Problem:**  While doing any operation on Carbon File if file status acquiring throws exception then it is logged and not thrown again therefore if any further operation on that object required filestatus then it can throw NPE.
    
    **Solution:** Add null check and throw proper exception.
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata fix_npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2536.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2536
    
----
commit 060dc7fc461d9f2eec6603b45651d76588dbb9bc
Author: kunal642 <ku...@...>
Date:   2018-07-22T11:39:08Z

    added null check on filestatus

----


---

[GitHub] carbondata issue #2536: [CARBONDATA-2766] Added null check on filestatus

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2536
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6138/



---

[GitHub] carbondata pull request #2536: [CARBONDATA-2766] Added null check on filesta...

Posted by kunal642 <gi...@git.apache.org>.

Github user kunal642 closed the pull request at:

    https://github.com/apache/carbondata/pull/2536


---

[GitHub] carbondata issue #2536: [CARBONDATA-2766] Added null check on filestatus

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2536
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7377/



---

[GitHub] carbondata issue #2536: [CARBONDATA-2766] Added null check on filestatus

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2536
  
    why not throw IOException so that user can explicitly know and handle the exception.
    In your implementation, when there is a problem, the user will get RTE instead of NPE which I think there’s no difference.


---

[GitHub] carbondata issue #2536: [CARBONDATA-2766] Added null check on filestatus

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2536
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5953/



---

[GitHub] carbondata issue #2536: [CARBONDATA-2766] Added null check on filestatus

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2536
  
    Besides, there are too many duplicate code here to check null.
    
    If null will cause EXCEPTION for all the operations, why not throw EXCEPTION as soon as the variable filestatus is assigned in setter or constructor?


---

[GitHub] carbondata issue #2536: [CARBONDATA-2766] Added null check on filestatus

Posted by kunal642 <gi...@git.apache.org>.

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2536
  
    @xuchuanyin Closing this PR. Refer #2465


---