You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by kg...@apache.org on 2022/04/15 12:56:41 UTC
[superset] branch master updated: chore: Clean redundant dependency from useMemo dep array (#19732)
This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new b7759e6fd1 chore: Clean redundant dependency from useMemo dep array (#19732)
b7759e6fd1 is described below
commit b7759e6fd138aff83cc80eea23069268ecc717d9
Author: Kamil Gabryjelski <ka...@gmail.com>
AuthorDate: Fri Apr 15 14:56:34 2022 +0200
chore: Clean redundant dependency from useMemo dep array (#19732)
---
.../components/controls/DndColumnSelectControl/DndColumnSelect.tsx | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
index 529d4c7c78..e7b25908cf 100644
--- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
+++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
@@ -126,10 +126,7 @@ export function DndColumnSelect(props: DndColumnSelectProps) {
[onChange, optionSelector],
);
- const popoverOptions = useMemo(
- () => Object.values(options),
- [optionSelector.values, options],
- );
+ const popoverOptions = useMemo(() => Object.values(options), [options]);
const valuesRenderer = useCallback(
() =>