You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/06/23 09:04:00 UTC

[GitHub] [zeppelin] chillinger opened a new pull request #4149: [ZEPPELIN-5424] Clarify LDAPRealm Bug/Limit

chillinger opened a new pull request #4149:
URL: https://github.com/apache/zeppelin/pull/4149


   Inform Users of Zeppelin 0.9 of a limitation in LDAPRealm
   
   ### What is this PR for?
   As I spent a lot of Time figuring out this Problem with LDAPRealm I would like to inform other Users of this current Limitation
   
   ### What type of PR is it?
   Documentation
   
   ### Todos
   * republish Zeppelin 0.9 Documentation
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5424
   
   ### How should this be tested?
   No Code testing is needed, maybe verify the documented Limitation
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] chillinger commented on a change in pull request #4149: [ZEPPELIN-5424] Clarify LDAPRealm Bug/Limit

Posted by GitBox <gi...@apache.org>.
chillinger commented on a change in pull request #4149:
URL: https://github.com/apache/zeppelin/pull/4149#discussion_r659494036



##########
File path: docs/setup/security/shiro_authentication.md
##########
@@ -195,6 +195,7 @@ Add the following line in the `shiro.ini` file:
 ``` 
 ldapRealm.hadoopSecurityCredentialPath = jceks://file/user/zeppelin/conf/zeppelin.jceks
 ```
+**Caution** due to a bug in LDAPRealm only ```ldapRealm.pagingSize``` results will be fetched from LDAP. In big directory Trees this may cause missing Roles. Try limiting the search Scope using ```ldapRealm.groupSearchBase``` or narrow down the required Groups using ```ldapRealm.groupSearchFilter```

Review comment:
       Hi @zjffdu I will not find the time to fix this myself unfortunately




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] chillinger commented on a change in pull request #4149: [ZEPPELIN-5424] Clarify LDAPRealm Bug/Limit

Posted by GitBox <gi...@apache.org>.
chillinger commented on a change in pull request #4149:
URL: https://github.com/apache/zeppelin/pull/4149#discussion_r657704887



##########
File path: docs/setup/security/shiro_authentication.md
##########
@@ -195,6 +195,7 @@ Add the following line in the `shiro.ini` file:
 ``` 
 ldapRealm.hadoopSecurityCredentialPath = jceks://file/user/zeppelin/conf/zeppelin.jceks
 ```
+**Caution** due to a bug in LDAPRealm only ```ldapRealm.pagingSize``` results will be fetched from LDAP. In big directory Trees this may cause missing Roles. Try limiting the search Scope using ```ldapRealm.groupSearchBase``` or narrow down the required Groups using ```ldapRealm.groupSearchFilter```

Review comment:
       @zjffdu I agree that this should be fixed for the next version of Zeppelin.
   
   But I would also like to update the Documentation for the current version, as 0.9 contains this error and that will not change. Users should be informed of that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on a change in pull request #4149: [ZEPPELIN-5424] Clarify LDAPRealm Bug/Limit

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4149:
URL: https://github.com/apache/zeppelin/pull/4149#discussion_r657709394



##########
File path: docs/setup/security/shiro_authentication.md
##########
@@ -195,6 +195,7 @@ Add the following line in the `shiro.ini` file:
 ``` 
 ldapRealm.hadoopSecurityCredentialPath = jceks://file/user/zeppelin/conf/zeppelin.jceks
 ```
+**Caution** due to a bug in LDAPRealm only ```ldapRealm.pagingSize``` results will be fetched from LDAP. In big directory Trees this may cause missing Roles. Try limiting the search Scope using ```ldapRealm.groupSearchBase``` or narrow down the required Groups using ```ldapRealm.groupSearchFilter```

Review comment:
       Thanks for clarification, that make sense to me. Do you have plan to create a PR to fix this issue ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on a change in pull request #4149: [ZEPPELIN-5424] Clarify LDAPRealm Bug/Limit

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4149:
URL: https://github.com/apache/zeppelin/pull/4149#discussion_r657183820



##########
File path: docs/setup/security/shiro_authentication.md
##########
@@ -195,6 +195,7 @@ Add the following line in the `shiro.ini` file:
 ``` 
 ldapRealm.hadoopSecurityCredentialPath = jceks://file/user/zeppelin/conf/zeppelin.jceks
 ```
+**Caution** due to a bug in LDAPRealm only ```ldapRealm.pagingSize``` results will be fetched from LDAP. In big directory Trees this may cause missing Roles. Try limiting the search Scope using ```ldapRealm.groupSearchBase``` or narrow down the required Groups using ```ldapRealm.groupSearchFilter```

Review comment:
       Do. you mean bug of `org.apache.zeppelin.realm.LdapRealm`, if so I think we should fix it instead of using doc to warn user

##########
File path: docs/setup/security/shiro_authentication.md
##########
@@ -195,6 +195,7 @@ Add the following line in the `shiro.ini` file:
 ``` 
 ldapRealm.hadoopSecurityCredentialPath = jceks://file/user/zeppelin/conf/zeppelin.jceks
 ```
+**Caution** due to a bug in LDAPRealm only ```ldapRealm.pagingSize``` results will be fetched from LDAP. In big directory Trees this may cause missing Roles. Try limiting the search Scope using ```ldapRealm.groupSearchBase``` or narrow down the required Groups using ```ldapRealm.groupSearchFilter```

Review comment:
       Do you mean bug of `org.apache.zeppelin.realm.LdapRealm`, if so I think we should fix it instead of using doc to warn user




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] asfgit closed pull request #4149: [ZEPPELIN-5424] Clarify LDAPRealm Bug/Limit

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4149:
URL: https://github.com/apache/zeppelin/pull/4149


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org