You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by ph...@apache.org on 2009/03/12 01:24:49 UTC

svn commit: r752711 - in /hadoop/zookeeper/branches/branch-3.1: CHANGES.txt src/c/src/zk_adaptor.h

Author: phunt
Date: Thu Mar 12 00:24:49 2009
New Revision: 752711

URL: http://svn.apache.org/viewvc?rev=752711&view=rev
Log:
ZOOKEEPER-333. helgrind thread issues identified in mt c client code

Modified:
    hadoop/zookeeper/branches/branch-3.1/CHANGES.txt
    hadoop/zookeeper/branches/branch-3.1/src/c/src/zk_adaptor.h

Modified: hadoop/zookeeper/branches/branch-3.1/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/zookeeper/branches/branch-3.1/CHANGES.txt?rev=752711&r1=752710&r2=752711&view=diff
==============================================================================
--- hadoop/zookeeper/branches/branch-3.1/CHANGES.txt (original)
+++ hadoop/zookeeper/branches/branch-3.1/CHANGES.txt Thu Mar 12 00:24:49 2009
@@ -22,6 +22,9 @@
 
   ZOOKEEPER-281. autoreconf fails for /zookeeper-3.0.1/src/c/ (phunt)
 
+  ZOOKEEPER-333. helgrind thread issues identified in mt c client code
+  (mahadev via phunt)
+
 IMPROVEMENTS:
 
   ZOOKEEPER-279. Allow specialization of quorum config parsing

Modified: hadoop/zookeeper/branches/branch-3.1/src/c/src/zk_adaptor.h
URL: http://svn.apache.org/viewvc/hadoop/zookeeper/branches/branch-3.1/src/c/src/zk_adaptor.h?rev=752711&r1=752710&r2=752711&view=diff
==============================================================================
--- hadoop/zookeeper/branches/branch-3.1/src/c/src/zk_adaptor.h (original)
+++ hadoop/zookeeper/branches/branch-3.1/src/c/src/zk_adaptor.h Thu Mar 12 00:24:49 2009
@@ -54,7 +54,7 @@
 struct _completion_list;
 
 typedef struct _buffer_head {
-    struct _buffer_list *head;
+    struct _buffer_list *volatile head;
     struct _buffer_list *last;
 #ifdef THREADED
     pthread_mutex_t lock;
@@ -62,7 +62,7 @@
 } buffer_head_t;
 
 typedef struct _completion_head {
-    struct _completion_list *head;
+    struct _completion_list *volatile head;
     struct _completion_list *last;
 #ifdef THREADED
     pthread_cond_t cond;