You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2018/07/24 15:08:59 UTC
[GitHub] activemq-artemis pull request #2192: ARTEMIS-1988 Do not clear activate call...
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2192
ARTEMIS-1988 Do not clear activate callbacks on stop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1988
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2192
----
commit 750039d3478ed93d9b3b374025dd71d099fa0e12
Author: Martyn Taylor <mt...@...>
Date: 2018-07-24T15:08:19Z
ARTEMIS-1988 Do not clear activate callbacks on stop
----
---
[GitHub] activemq-artemis pull request #2192: ARTEMIS-1988 Do not clear activate call...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2192
---
[GitHub] activemq-artemis issue #2192: ARTEMIS-1988 Do not clear activate callbacks o...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2192
@jbertram Can you take a look please.
---
[GitHub] activemq-artemis issue #2192: ARTEMIS-1988 Do not clear activate callbacks o...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2192
@clebertsuconic fixed. This should never have been changed. The original change removes the ability to track life cycle changes once the broker has been stopped and started again. The change broke the API.
---
[GitHub] activemq-artemis issue #2192: ARTEMIS-1988 Do not clear activate callbacks o...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2192
in what situation was this a bug?
Did you run the entire testsuite?
---
[GitHub] activemq-artemis pull request #2192: ARTEMIS-1988 Do not clear activate call...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2192#discussion_r205094364
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -1109,9 +1109,7 @@ void stop(boolean failoverOnServerShutdown, final boolean criticalIOError, boole
storageManager = null;
sessions.clear();
-
- activateCallbacks.clear();
--- End diff --
@mtaylor you basically are trying to revert 36fc14a30d6f1128c525c91cc9f8752fdd3f540c / ARTEMIS-1704
if you do revert this, please remove the test.
@jbertram what is the intent, and why @mtaylor is reverting this?
---
[GitHub] activemq-artemis pull request #2192: ARTEMIS-1988 Do not clear activate call...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2192#discussion_r205096243
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -1109,9 +1109,7 @@ void stop(boolean failoverOnServerShutdown, final boolean criticalIOError, boole
storageManager = null;
sessions.clear();
-
- activateCallbacks.clear();
--- End diff --
this is also failing checkstyle. there's an extra space somewhere.
---
[GitHub] activemq-artemis pull request #2192: ARTEMIS-1988 Do not clear activate call...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2192#discussion_r205093692
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -1109,9 +1109,7 @@ void stop(boolean failoverOnServerShutdown, final boolean criticalIOError, boole
storageManager = null;
sessions.clear();
-
- activateCallbacks.clear();
--- End diff --
This will make ClearActivateCallbackTest to fail
---