You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/13 22:28:29 UTC
[GitHub] [maven-dependency-plugin] slawekjaranowski opened a new pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
slawekjaranowski opened a new pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195
- use maven-site-plugin in IT test
- remove dependency to doxia, it is transitive from maven-reporting-impl
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195#discussion_r805426960
##########
File path: src/it/projects/analyze-report/pom.xml
##########
@@ -59,13 +59,40 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
- <configuration>
- <outputXML>true</outputXML>
- <scriptableOutput>true</scriptableOutput>
- <verbose>true</verbose>
- </configuration>
+ <version>@project.version@</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>3.10.0</version>
Review comment:
IMHO not a good idea. It's not worth delaying this, and it's no harder to update to 3.11.0 before or after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195#discussion_r805425728
##########
File path: src/it/projects/analyze-report/pom.xml
##########
@@ -59,13 +59,40 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
- <configuration>
- <outputXML>true</outputXML>
- <scriptableOutput>true</scriptableOutput>
- <verbose>true</verbose>
- </configuration>
+ <version>@project.version@</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>3.10.0</version>
Review comment:
3.11.0 is in the works which upgrades the entire stack. I recommend to wait for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a change in pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195#discussion_r805599521
##########
File path: src/it/projects/analyze-report/pom.xml
##########
@@ -59,13 +59,40 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
- <configuration>
- <outputXML>true</outputXML>
- <scriptableOutput>true</scriptableOutput>
- <verbose>true</verbose>
- </configuration>
+ <version>@project.version@</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>3.10.0</version>
Review comment:
This is IT test ... project also override m-site-plugin from parent
In such situation will be good to have some possibility to inherit plugin version from parent pom, in other case IT test will have outdated dependency in some time and will be not maintain
So I prefer to update m-site-p in separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195#discussion_r805425728
##########
File path: src/it/projects/analyze-report/pom.xml
##########
@@ -59,13 +59,40 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
- <configuration>
- <outputXML>true</outputXML>
- <scriptableOutput>true</scriptableOutput>
- <verbose>true</verbose>
- </configuration>
+ <version>@project.version@</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>3.10.0</version>
Review comment:
3.11.0 is in the works which upgrades the entire stack. I recommend to wait for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195#discussion_r805540123
##########
File path: src/it/projects/analyze-report/pom.xml
##########
@@ -59,13 +59,40 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
- <configuration>
- <outputXML>true</outputXML>
- <scriptableOutput>true</scriptableOutput>
- <verbose>true</verbose>
- </configuration>
+ <version>@project.version@</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>3.10.0</version>
Review comment:
Three days more or less, who cares?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #195: [MDEP-788] Upgrade maven-reporting-impl to version 3.1.0
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #195:
URL: https://github.com/apache/maven-dependency-plugin/pull/195#discussion_r805426960
##########
File path: src/it/projects/analyze-report/pom.xml
##########
@@ -59,13 +59,40 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
- <configuration>
- <outputXML>true</outputXML>
- <scriptableOutput>true</scriptableOutput>
- <verbose>true</verbose>
- </configuration>
+ <version>@project.version@</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>3.10.0</version>
Review comment:
IMHO not a good idea. It's not worth delaying this, and it's no harder to update to 3.11.0 before or after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org