You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/19 14:23:42 UTC
[GitHub] [rocketmq] xiaoyaofawai opened a new issue #2910: The jedgment 'writePos - lastCommittedPosition > commitLeastPages' in the method 'commit0' of class 'MappedFile' is meaningless
xiaoyaofawai opened a new issue #2910:
URL: https://github.com/apache/rocketmq/issues/2910
I think the jedgment '**writePos - lastCommittedPosition > commitLeastPages**' in the method 'commit0' of class 'MappedFile' is meaningless in the version 4.8.0.
As you can see. 'writePos - lastCommittedPosition' represents the amount of data that has not been committed, it's in byte. but commitLeastPages represents the least pages(OS_PAGE) should be committed. so '**writePos - lastCommittedPosition > commitLeastPages**' is meaningless, although this expression does not cause errors.
I think this expression should be 'writePos - lastCommittedPosition > 0', it used to determine whether there is uncommitted data. Do you think so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyaofawai removed a comment on issue #2910: The jedgment 'writePos - lastCommittedPosition > commitLeastPages' in the method 'commit0' of class 'MappedFile' is meaningless
Posted by GitBox <gi...@apache.org>.
xiaoyaofawai removed a comment on issue #2910:
URL: https://github.com/apache/rocketmq/issues/2910#issuecomment-866699315
why no one answer me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyaofawai commented on issue #2910: The jedgment 'writePos - lastCommittedPosition > commitLeastPages' in the method 'commit0' of class 'MappedFile' is meaningless
Posted by GitBox <gi...@apache.org>.
xiaoyaofawai commented on issue #2910:
URL: https://github.com/apache/rocketmq/issues/2910#issuecomment-866699315
why no one answer me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyaofawai commented on issue #2910: The jedgment 'writePos - lastCommittedPosition > commitLeastPages' in the method 'commit0' of class 'MappedFile' is meaningless
Posted by GitBox <gi...@apache.org>.
xiaoyaofawai commented on issue #2910:
URL: https://github.com/apache/rocketmq/issues/2910#issuecomment-866646863
why no one answer me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyaofawai removed a comment on issue #2910: The jedgment 'writePos - lastCommittedPosition > commitLeastPages' in the method 'commit0' of class 'MappedFile' is meaningless
Posted by GitBox <gi...@apache.org>.
xiaoyaofawai removed a comment on issue #2910:
URL: https://github.com/apache/rocketmq/issues/2910#issuecomment-866646863
why no one answer me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyaofawai closed issue #2910: The jedgment 'writePos - lastCommittedPosition > commitLeastPages' in the method 'commit0' of class 'MappedFile' is meaningless
Posted by GitBox <gi...@apache.org>.
xiaoyaofawai closed issue #2910:
URL: https://github.com/apache/rocketmq/issues/2910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org