You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/12/13 03:27:57 UTC

[PR] flink-rss. [incubator-uniffle]

slfan1989 opened a new pull request, #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366

   <!--
   1. Title: [#<issue>] <type>(<scope>): <subject>
      Examples:
        - "[#123] feat(operator): support xxx"
        - "[#233] fix: check null before access result in xxx"
        - "[MINOR] refactor: fix typo in variable name"
        - "[MINOR] docs: fix typo in README"
        - "[#255] test: fix flaky test NameOfTheTest"
      Reference: https://www.conventionalcommits.org/en/v1.0.0/
   2. Contributor guidelines:
      https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
   3. If the PR is unfinished, please mark this PR as draft.
   -->
   
   ### What changes were proposed in this pull request?
   
   (Please outline the changes and how this PR fixes the issue.)
   
   ### Why are the changes needed?
   
   (Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, describe the bug.)
   
   Fix: # (issue)
   
   ### Does this PR introduce _any_ user-facing change?
   
   (Please list the user-facing changes introduced by your change, including
     1. Change in user-facing APIs.
     2. Addition or removal of property keys.)
   
   No.
   
   ### How was this patch tested?
   
   (Please test your changes, and provide instructions on how to test it:
     1. If you add a feature or fix a bug, add a test to cover your changes. 
     2. If you fix a flaky test, repeat it for many times to prove it works.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on code in PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#discussion_r1430035668


##########
client-flink/common/src/main/java/org/apache/uniffle/shuffle/RssShuffleMaster.java:
##########
@@ -0,0 +1,352 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.uniffle.shuffle;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.MemorySize;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionID;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
+import org.apache.flink.runtime.shuffle.JobShuffleContext;
+import org.apache.flink.runtime.shuffle.PartitionDescriptor;
+import org.apache.flink.runtime.shuffle.ProducerDescriptor;
+import org.apache.flink.runtime.shuffle.ShuffleDescriptor;
+import org.apache.flink.runtime.shuffle.ShuffleEnvironment;
+import org.apache.flink.runtime.shuffle.ShuffleMaster;
+import org.apache.flink.runtime.shuffle.ShuffleMasterContext;
+import org.apache.flink.runtime.shuffle.TaskInputsOutputsDescriptor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.uniffle.client.api.ShuffleWriteClient;
+import org.apache.uniffle.client.util.ClientUtils;
+import org.apache.uniffle.common.PartitionRange;
+import org.apache.uniffle.common.RemoteStorageInfo;
+import org.apache.uniffle.common.ShuffleAssignmentsInfo;
+import org.apache.uniffle.common.ShuffleDataDistributionType;
+import org.apache.uniffle.common.ShuffleServerInfo;
+import org.apache.uniffle.common.config.RssClientConf;
+import org.apache.uniffle.common.exception.RssException;
+import org.apache.uniffle.common.util.RetryUtils;
+import org.apache.uniffle.common.util.ThreadUtils;
+import org.apache.uniffle.shuffle.exception.ShuffleException;
+import org.apache.uniffle.shuffle.resource.DefaultRssShuffleResource;
+import org.apache.uniffle.shuffle.resource.RssShuffleResourceDescriptor;
+import org.apache.uniffle.shuffle.utils.FlinkShuffleUtils;
+
+import static org.apache.uniffle.shuffle.RssFlinkConfig.*;
+import static org.apache.uniffle.shuffle.utils.FlinkShuffleUtils.getShuffleDataDistributionType;
+
+public class RssShuffleMaster implements ShuffleMaster<RssShuffleDescriptor> {
+
+  private static final Logger LOG = LoggerFactory.getLogger(RssShuffleMaster.class);
+
+  //
+  private final ShuffleMasterContext shuffleMasterContext;
+  private final RssFlinkApplication rssFlinkApplication;
+
+  //
+  protected ShuffleWriteClient shuffleWriteClient;
+
+  //
+  private boolean heartbeatStarted = false;
+  private final ScheduledExecutorService heartBeatScheduledExecutorService;
+
+  //
+  private final ScheduledExecutorService executorService;
+
+  private final Configuration config;
+
+  public RssShuffleMaster(ShuffleMasterContext shuffleMasterContext) {
+    this.shuffleMasterContext = shuffleMasterContext;
+    this.config = shuffleMasterContext.getConfiguration();
+    this.rssFlinkApplication = new RssFlinkApplication();
+    this.heartBeatScheduledExecutorService =
+        ThreadUtils.getDaemonSingleThreadScheduledExecutor("uniffle-rss-heartbeat");
+    this.executorService =
+        ThreadUtils.getDaemonSingleThreadScheduledExecutor("uniffle-shuffle-master-executor");
+  }
+
+  protected void registerCoordinator(Configuration config) {
+    String coordinators = config.getString(RssFlinkConfig.RSS_COORDINATOR_QUORM);
+    LOG.info("Start Registering Coordinator {}.", coordinators);
+    shuffleWriteClient.registerCoordinators(coordinators);
+  }
+
+  @Override
+  public void close() throws Exception {
+    if (heartBeatScheduledExecutorService != null) {
+      heartBeatScheduledExecutorService.shutdownNow();
+    }
+    if (executorService != null) {
+      executorService.shutdownNow();
+    }
+    if (shuffleWriteClient != null) {
+      shuffleWriteClient.close();
+    }
+  }
+
+  /**
+   * Registers the target job together with the corresponding {@link JobShuffleContext} to this
+   * shuffle master. Through the shuffle context, one can obtain some basic information like job ID,
+   * job configuration. It enables ShuffleMaster to notify JobMaster about lost result partitions,
+   * so that JobMaster can identify and reproduce unavailable partitions earlier.
+   *
+   * @param context the corresponding shuffle context of the target job.
+   */
+  @Override
+  public void registerJob(JobShuffleContext context) {
+    JobID jobID = context.getJobId();
+    if (shuffleWriteClient == null) {
+      synchronized (RssShuffleMaster.class) {

Review Comment:
   If it is a class object here, it may be heavier. Is the object RssShuffleMaster itself enough?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1876290880

   > Is there a design doc for this one? I can help review this feature.
   
   Thank you for reviewing the code! The documentation is being improved. I will update it as soon as possible. Unit tests are still being added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1928474975

   I will continue to follow up on this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "chenglong-bigdata (via GitHub)" <gi...@apache.org>.
chenglong-bigdata commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1874742824

   > @chenglong-bigdata Can you help review the code?
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1968024857

   @chenglong-bigdata We will continue to follow up on this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] flink-rss. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1853211098

   @jerqi @zuston I started to submit the code about Flink rss. I still need to spend some time merging the local code. It will take about 2-3 days to complete the submission.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1859090483

   buffer: https://flink.apache.org/2019/06/05/a-deep-dive-into-flinks-network-stack/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1853216033

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`ecbf2e7`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/ecbf2e79423505dd44bf54c612572c5c9da71175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.22% compared to head [(`2d660ed`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.14%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1366      +/-   ##
   ============================================
   + Coverage     53.22%   54.14%   +0.92%     
   + Complexity     2715     2327     -388     
   ============================================
     Files           418      359      -59     
     Lines         23932    16664    -7268     
     Branches       2043     1522     -521     
   ============================================
   - Hits          12738     9023    -3715     
   + Misses        10408     7146    -3262     
   + Partials        786      495     -291     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1366?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1853832437

   @chenglong-bigdata Can you help review the code? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 closed pull request #1366: [FEATURE] Support Flink RSS.
URL: https://github.com/apache/incubator-uniffle/pull/1366


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on code in PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#discussion_r1432051400


##########
client-flink/common/src/main/java/org/apache/uniffle/shuffle/RssShuffleMaster.java:
##########
@@ -0,0 +1,352 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.uniffle.shuffle;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.MemorySize;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionID;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
+import org.apache.flink.runtime.shuffle.JobShuffleContext;
+import org.apache.flink.runtime.shuffle.PartitionDescriptor;
+import org.apache.flink.runtime.shuffle.ProducerDescriptor;
+import org.apache.flink.runtime.shuffle.ShuffleDescriptor;
+import org.apache.flink.runtime.shuffle.ShuffleEnvironment;
+import org.apache.flink.runtime.shuffle.ShuffleMaster;
+import org.apache.flink.runtime.shuffle.ShuffleMasterContext;
+import org.apache.flink.runtime.shuffle.TaskInputsOutputsDescriptor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.uniffle.client.api.ShuffleWriteClient;
+import org.apache.uniffle.client.util.ClientUtils;
+import org.apache.uniffle.common.PartitionRange;
+import org.apache.uniffle.common.RemoteStorageInfo;
+import org.apache.uniffle.common.ShuffleAssignmentsInfo;
+import org.apache.uniffle.common.ShuffleDataDistributionType;
+import org.apache.uniffle.common.ShuffleServerInfo;
+import org.apache.uniffle.common.config.RssClientConf;
+import org.apache.uniffle.common.exception.RssException;
+import org.apache.uniffle.common.util.RetryUtils;
+import org.apache.uniffle.common.util.ThreadUtils;
+import org.apache.uniffle.shuffle.exception.ShuffleException;
+import org.apache.uniffle.shuffle.resource.DefaultRssShuffleResource;
+import org.apache.uniffle.shuffle.resource.RssShuffleResourceDescriptor;
+import org.apache.uniffle.shuffle.utils.FlinkShuffleUtils;
+
+import static org.apache.uniffle.shuffle.RssFlinkConfig.*;
+import static org.apache.uniffle.shuffle.utils.FlinkShuffleUtils.getShuffleDataDistributionType;
+
+public class RssShuffleMaster implements ShuffleMaster<RssShuffleDescriptor> {
+
+  private static final Logger LOG = LoggerFactory.getLogger(RssShuffleMaster.class);
+
+  //
+  private final ShuffleMasterContext shuffleMasterContext;
+  private final RssFlinkApplication rssFlinkApplication;
+
+  //
+  protected ShuffleWriteClient shuffleWriteClient;
+
+  //
+  private boolean heartbeatStarted = false;
+  private final ScheduledExecutorService heartBeatScheduledExecutorService;
+
+  //
+  private final ScheduledExecutorService executorService;
+
+  private final Configuration config;
+
+  public RssShuffleMaster(ShuffleMasterContext shuffleMasterContext) {
+    this.shuffleMasterContext = shuffleMasterContext;
+    this.config = shuffleMasterContext.getConfiguration();
+    this.rssFlinkApplication = new RssFlinkApplication();
+    this.heartBeatScheduledExecutorService =
+        ThreadUtils.getDaemonSingleThreadScheduledExecutor("uniffle-rss-heartbeat");
+    this.executorService =
+        ThreadUtils.getDaemonSingleThreadScheduledExecutor("uniffle-shuffle-master-executor");
+  }
+
+  protected void registerCoordinator(Configuration config) {
+    String coordinators = config.getString(RssFlinkConfig.RSS_COORDINATOR_QUORM);
+    LOG.info("Start Registering Coordinator {}.", coordinators);
+    shuffleWriteClient.registerCoordinators(coordinators);
+  }
+
+  @Override
+  public void close() throws Exception {
+    if (heartBeatScheduledExecutorService != null) {
+      heartBeatScheduledExecutorService.shutdownNow();
+    }
+    if (executorService != null) {
+      executorService.shutdownNow();
+    }
+    if (shuffleWriteClient != null) {
+      shuffleWriteClient.close();
+    }
+  }
+
+  /**
+   * Registers the target job together with the corresponding {@link JobShuffleContext} to this
+   * shuffle master. Through the shuffle context, one can obtain some basic information like job ID,
+   * job configuration. It enables ShuffleMaster to notify JobMaster about lost result partitions,
+   * so that JobMaster can identify and reproduce unavailable partitions earlier.
+   *
+   * @param context the corresponding shuffle context of the target job.
+   */
+  @Override
+  public void registerJob(JobShuffleContext context) {
+    JobID jobID = context.getJobId();
+    if (shuffleWriteClient == null) {
+      synchronized (RssShuffleMaster.class) {

Review Comment:
   Thank you helping to review the code! This PR still needs to be improved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [FEATURE] Support Flink RSS. [incubator-uniffle]

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #1366:
URL: https://github.com/apache/incubator-uniffle/pull/1366#issuecomment-1876218971

   Is there a design doc for this one? I can help review this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org