You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/04/22 12:16:06 UTC

svn commit: r1900154 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDStream.java

Author: tilman
Date: Fri Apr 22 12:16:06 2022
New Revision: 1900154

URL: http://svn.apache.org/viewvc?rev=1900154&view=rev
Log:
PDFBOX-4892: optimize, as suggested by Valery Bokov

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDStream.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDStream.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDStream.java?rev=1900154&r1=1900153&r2=1900154&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDStream.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDStream.java Fri Apr 22 12:16:06 2022
@@ -512,22 +512,18 @@ public class PDStream implements COSObje
     {
         PDMetadata retval = null;
         COSBase mdStream = stream.getDictionaryObject(COSName.METADATA);
-        if (mdStream != null)
+        if (mdStream instanceof COSStream)
         {
-            if (mdStream instanceof COSStream)
-            {
-                retval = new PDMetadata((COSStream) mdStream);
-            } 
-            else if (mdStream instanceof COSNull)
-            {
-                // null is authorized
-            } 
-            else
-            {
-                throw new IllegalStateException(
-                        "Expected a COSStream but was a "
-                                + mdStream.getClass().getSimpleName());
-            }
+            retval = new PDMetadata((COSStream) mdStream);
+        } 
+        else if (mdStream instanceof COSNull)
+        {
+            // null is authorized
+        } 
+        else if (mdStream != null)
+        {
+            throw new IllegalStateException("Expected a COSStream but was a "
+                            + mdStream.getClass().getSimpleName());
         }
         return retval;
     }