general/5760: Use of text type "t" in fopen call...

[Ian Turner <ia...@sequent.com>]

>Number:         5760
>Category:       general
>Synopsis:       Use of text type "t" in fopen call...
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          change-request
>Submitter-Id:   apache
>Arrival-Date:   Mon Feb 14 16:10:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     iant@sequent.com
>Release:        1.3.12-dev
>Organization:
apache
>Environment:
Sequent DYNIX/ptx v4.5.1
>Description:
A change was put into v1.3.11 to get around a problem with configuration files
and editiors on OS/2. The text mode flag was used in fopen() in src/main/util.c.
This change should have been IFDEF OS/2 as the Unix specifications (posix, unix98)
do not provide for a type/mode of "t" for fopen() and not all Unix implementations
ignore "t" like the "b" flag.

Diff provided below against v1.3.12-dev, request it be applied before v1.3.12
is released.
>How-To-Repeat:

>Fix:
*** util.c.orig Mon Feb 14 13:25:17 2000
--- util.c      Mon Feb 14 13:28:26 2000
***************
*** 809,815 ****
--- 809,820 ----
          return NULL;
      }
  
+ #ifdef OS2
      file = ap_pfopen(p, name, "rt");
+ #else
+     file = ap_pfopen(p, name, "r");
+ #endif
+ 
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <ap...@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]