[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #695: ci: separate daily ci and trigger daily ci only if labeled

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #695:
URL: https://github.com/apache/incubator-kvrocks/pull/695#discussion_r910179983


##########
.github/workflows/daily-ci.yaml:
##########
@@ -19,22 +19,22 @@ name: Daily CI
 
 on:
   pull_request:
-    paths:
-      - ".github/workflows/daily-ci.yaml"
+    types: [opened, synchronize, reopened, labeled]
   schedule:
-    # Daily run this action at 1am
     - cron: '0 1 * * *'
   workflow_dispatch:
 
 jobs:
   build-docker-image:
     name: Build Docker Image
+    if: |
+      (github.event_name != 'pull_request') ||
+      (github.event.action == 'labeled' && github.event.label.name == 'needs-daily-ci') ||
+      (github.event.action != 'labeled' && contains(github.event.pull_request.labels.*.name, 'needs-daily-ci'))

Review Comment:
   We can actually run kvrocks.yaml job everyday.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org