You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/07/13 07:22:14 UTC
Review Request 67903: Fixed breadcrumb links in site templates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67903/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Dave Lester, and Till Toenshoff.
Repository: mesos
Description
-------
This patch makes sure that we do not leak newlines into breadcrumb
links created from page titles, and fixes the handling of spaces which
are represented with dashes.
Diffs
-----
site/source/layouts/basic.erb fc59f00684b61c551f2705b77b3d66a017e1e76e
Diff: https://reviews.apache.org/r/67903/diff/1/
Testing
-------
Verified that the breadcrumb _Getting Started_ (explicit `breadcrumb` in yaml) and the _Documentation breadcrumb_ (reachable from any documentation page, e.g., http://mesos.apache.org/documentation/latest/committing/) have a valid link in the source without newline (some browsers seem to automagically clean up the broken link).
Thanks,
Benjamin Bannier
Re: Review Request 67903: Fixed breadcrumb links in site templates.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67903/#review206377
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On July 13, 2018, 7:22 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67903/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 7:22 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Dave Lester, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes sure that we do not leak newlines into breadcrumb
> links created from page titles, and fixes the handling of spaces which
> are represented with dashes.
>
>
> Diffs
> -----
>
> site/source/layouts/basic.erb fc59f00684b61c551f2705b77b3d66a017e1e76e
>
>
> Diff: https://reviews.apache.org/r/67903/diff/1/
>
>
> Testing
> -------
>
> Verified that the breadcrumb _Getting Started_ (explicit `breadcrumb` in yaml) and the _Documentation breadcrumb_ (reachable from any documentation page, e.g., http://mesos.apache.org/documentation/latest/committing/) have a valid link in the source without newline (some browsers seem to automagically clean up the broken link).
>
>
> Thanks,
>
> Benjamin Bannier
>
>