You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/03 18:32:53 UTC
[jira] [Commented] (RAVE-586) Break out the navbar
[ https://issues.apache.org/jira/browse/RAVE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267564#comment-13267564 ]
jiraposter@reviews.apache.org commented on RAVE-586:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4930/#review7504
-----------------------------------------------------------
Thanks a lot for the patch. I have a couple of comments, but I like where this is headed. One big blocker is that I am getting an error when running the following unit test:
Tests in error:
viewPerson_ShouldAddAttributeForUser(org.apache.rave.portal.web.controller.ProfileControllerTest)
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
<https://reviews.apache.org/r/4930/#comment16608>
Just a note, we will want to make this more dynamic in the future. Can you put a ticket in JIRA to expand on this concept? I don't think it should prevent application of this patch, but we need to make sure we track it.
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
<https://reviews.apache.org/r/4930/#comment16609>
Why starts with instead of equals?
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
<https://reviews.apache.org/r/4930/#comment16610>
You might just want to make the default URL / instead of /index.html.
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
<https://reviews.apache.org/r/4930/#comment16611>
seems like there is duplication of the same logic. consider abstracting into a private helper.
/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/NavigationItem.java
<https://reviews.apache.org/r/4930/#comment16612>
Please add JavaDoc for the new attribute
/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/header.tag
<https://reviews.apache.org/r/4930/#comment16613>
We need to define a better way of trimming navigation items based on security. Maybe associate specific nav items with roles.
Since URL testing was the model we were using before, I am OK with applying this so long as a ticket is created to update the NavigationItem & corresponding checks here to use roles or other permission structures.
- mfranklin
On 2012-04-29 22:36:46, Chris Geer wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4930/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-29 22:36:46)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Refactored the common navbar components to the header.tag file and included that in all relevant jsp files (except mobile). I also expanded the NavigationItem code to handle parameters for the navigation item text. Moved menu generation code to the ControllerUtils class. This should eventually be loaded from a DB per ticket RAVE-589
bq.
bq.
bq. This addresses bug RAVE-586.
bq. https://issues.apache.org/jira/browse/RAVE-586
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java 1331506
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1331506
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1331506
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java 1331506
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java 1331506
bq. /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/NavigationItem.java 1331506
bq. /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationItemTest.java 1331506
bq. /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/NavigationMenuTest.java 1331506
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp 1331506
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1331506
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1331506
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1331506
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1331506
bq. /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/header.tag 1331506
bq.
bq. Diff: https://reviews.apache.org/r/4930/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Went through all screens to verify items showed as expected and had the correct links.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Break out the navbar
> --------------------
>
> Key: RAVE-586
> URL: https://issues.apache.org/jira/browse/RAVE-586
> Project: Rave
> Issue Type: Sub-task
> Components: rave-portal
> Reporter: Chris Geer
>
> Break out the navbar (bar along the top)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira