You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/06 00:18:30 UTC
Review Request 24350: Fixed two flaky tests in
GarbageCollectorIntegrationTest.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24350/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
src/tests/gc_tests.cpp df15746
Diff: https://reviews.apache.org/r/24350/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 24350: Fixed two flaky tests in
GarbageCollectorIntegrationTest.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24350/#review49654
-----------------------------------------------------------
Ship it!
Hm.. this seems good for now. If there are a lot of these we may want to consider some alternatives, like advancing the clock of specific processes, but I'm not sure how well that works. Not sure..
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/24350/#comment86903>
"the slave" might re-register? Ditto below.
- Ben Mahler
On Aug. 5, 2014, 10:18 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24350/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 10:18 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp df15746
>
> Diff: https://reviews.apache.org/r/24350/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>