[GitHub] williaster commented on a change in pull request #5763: [SIP-5] Refactor rose

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5763: [SIP-5] Refactor rose
URL: https://github.com/apache/incubator-superset/pull/5763#discussion_r213808200
 
 

 ##########
 File path: superset/assets/src/visualizations/rose.js
 ##########
 @@ -1,11 +1,29 @@
 /* eslint no-use-before-define: ["error", { "functions": false }] */
 import d3 from 'd3';
+import PropTypes from 'prop-types';
 import nv from 'nvd3';
 import { d3TimeFormatPreset } from '../modules/utils';
 import { getColorFromScheme } from '../modules/colors';
-
 import './rose.css';
 
+const propTypes = {
+  // Data is an object hashed by numeric value, perhaps timestamp
 
 Review comment:
   Does it work do specify this like this? 
   
   ```javascript
   data: PropTypes.objectOf(
     PropTypes.arrayOf(PropTypes.shape({ ... }),
   ),
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org