You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/06/27 12:51:07 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request, #5019: Micrometer: Custom registry coverage is missing #5018
JiriOndrusek opened a new pull request, #5019:
URL: https://github.com/apache/camel-quarkus/pull/5019
fixes https://github.com/apache/camel-quarkus/issues/5018
Custom registry with counter metric (`camel-quarkus-counter`) with value 10 is registered into component `micrometerCustomRegistry`. Test verifies the starting value of `camel-quarkus-counter` to be 10.
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #5019: Micrometer: Custom registry coverage is missing #5018
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #5019:
URL: https://github.com/apache/camel-quarkus/pull/5019#discussion_r1244773918
##########
integration-tests/micrometer/src/main/java/org/apache/camel/quarkus/component/micrometer/it/MicrometerProducers.java:
##########
@@ -64,4 +67,16 @@ public Meter.Id map(Meter.Id id) {
};
}
+ @Singleton
+ @Produces
Review Comment:
Thanks! fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #5019: Micrometer: Custom registry coverage is missing #5018
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #5019:
URL: https://github.com/apache/camel-quarkus/pull/5019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #5019: Micrometer: Custom registry coverage is missing #5018
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #5019:
URL: https://github.com/apache/camel-quarkus/pull/5019#issuecomment-1609519417
Test scenario has to be complicated, switched to draft, until fix is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #5019: Micrometer: Custom registry coverage is missing #5018
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #5019:
URL: https://github.com/apache/camel-quarkus/pull/5019#issuecomment-1609442023
Unused method `setInstrumentedThreadPoolFactory` is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5019: Micrometer: Custom registry coverage is missing #5018
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #5019:
URL: https://github.com/apache/camel-quarkus/pull/5019#discussion_r1244734671
##########
integration-tests/micrometer/src/main/java/org/apache/camel/quarkus/component/micrometer/it/MicrometerProducers.java:
##########
@@ -64,4 +67,16 @@ public Meter.Id map(Meter.Id id) {
};
}
+ @Singleton
+ @Produces
Review Comment:
Nitpick - That's the JAX-RS `@Produces`, not the CDI one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org