You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/23 19:15:32 UTC
[GitHub] [nifi] jocovo opened a new pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…
jocovo opened a new pull request #5893:
URL: https://github.com/apache/nifi/pull/5893
… on each html tag (where possible) to meet WCAG 2.1 Accessibility standards.
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
These changes provide a dynamic way of ensuring every <html> tag has a "lang" attribute with a [valid BCP 47 language](https://www.w3.org/International/questions/qa-choosing-language-tags#question) value, which is used by accessibility devices like screen readers to correctly pronounce on-screen text. This also meets success criteria for [accessibility standards in WCAG 2.1](https://www.w3.org/WAI/WCAG21/Techniques/html/H57). Resolves ticket NIFI-9816.
Testing the changes in this PR requires manual inspection of the <html> elements on the affected pages, noting that the changes in the nifi-web-api package are verified by inspecting the contents of the Documentation view's iframe.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jocovo commented on pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…
Posted by GitBox <gi...@apache.org>.
jocovo commented on pull request #5893:
URL: https://github.com/apache/nifi/pull/5893#issuecomment-1077897938
@exceptionfactory I just pushed some changes I missed the first time around. Can you please re-approve the workflow process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5893:
URL: https://github.com/apache/nifi/pull/5893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jocovo commented on pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…
Posted by GitBox <gi...@apache.org>.
jocovo commented on pull request #5893:
URL: https://github.com/apache/nifi/pull/5893#issuecomment-1076741512
I _had_ been wondering if I was over-engineering this solution given the current lack of localization. Hard-coding "en" would accurately represent the site's contents as it stands now, so I think that's a good idea. Will make the changes and push them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #5893:
URL: https://github.com/apache/nifi/pull/5893#issuecomment-1076744163
> Will make the changes and push them.
Sounds good, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jocovo commented on pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…
Posted by GitBox <gi...@apache.org>.
jocovo commented on pull request #5893:
URL: https://github.com/apache/nifi/pull/5893#issuecomment-1079236592
@exceptionfactory Everything looks good on my end. Do you approve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org