You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/12/24 05:05:11 UTC
[GitHub] tajo pull request: TAJO-1228: TajoClient should communicate with o...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/317
TAJO-1228: TajoClient should communicate with only TajoMaster without TajoWorker.
See the description at https://issues.apache.org/jira/browse/TAJO-1228.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/317.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #317
----
commit 64fb64ea9b3de3681a22c9f64e90beff06d001e1
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-21T11:23:17Z
Initial work
commit 0241bbcd86517604cc997471860b1f5af4a2f4b5
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-21T12:19:24Z
All test passed after getStatus from TajoMaster.
commit 01a1aed280b0007eb2d07b6548660e7eba18d12a
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-21T15:37:37Z
Completely remove connection of query master of query status.
commit a8983b73911f8c25cac270f04137101d2cb2930d
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-24T02:16:25Z
Passed all unit tests and removed worker client service.
commit 546837ee8176ebecc38f14050fdbc0394ea0fd43
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-24T03:15:37Z
Remove queryMasterMap from SessionConnection.
commit e158fe72fecb111fbb7b72f8c76397901b6762a2
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-24T03:47:34Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1228
Conflicts:
tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
commit 9de88de5da0a27145ae3626ed2c9db47b0d8092d
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-24T04:03:59Z
Clean up codes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1228: TajoClient should communicate with o...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/317#issuecomment-68147410
Hi @hyunsik
If possible, could you check the patch on testing cluster?
I failed Q3 query on tpc-h benchmark dataset with the patch as follows:
2014-12-27 01:18:08,273 ERROR org.apache.tajo.catalog.CatalogServer: java.lang.NullPointerException
2014-12-27 01:18:08,273 ERROR org.apache.tajo.catalog.AbstractCatalogClient: com.google.protobuf.ServiceException: java.lang.NullPointerException
com.google.protobuf.ServiceException: com.google.protobuf.ServiceException: java.lang.NullPointerException
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:105)
at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:243)
at org.apache.tajo.catalog.AbstractCatalogClient.getTableDesc(AbstractCatalogClient.java:262)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitRelation(LogicalPlanPreprocessor.java:385)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitRelation(LogicalPlanPreprocessor.java:44)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:98)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visitRelationList(BaseAlgebraVisitor.java:418)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:95)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitProjection(LogicalPlanPreprocessor.java:197)
at org.apache.tajo.plan.LogicalPlanPreprocessor.visitProjection(LogicalPlanPreprocessor.java:44)
at org.apache.tajo.plan.algebra.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:59)
at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:141)
at org.apache.tajo.plan.LogicalPlanner.createPlan(LogicalPlanner.java:131)
at org.apache.tajo.master.GlobalEngine.createLogicalPlan(GlobalEngine.java:232)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:161)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:284)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:543)
at org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.messageReceived(BlockingRpcServer.java:103)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1228: TajoClient should communicate with o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1228: TajoClient should communicate with o...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/317#issuecomment-68144062
Hi @hyunsik
Could you rebase sources against the apache master branch?
I can't merge as follows:
Auto-merging tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
CONFLICT (content): Merge conflict in tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
Auto-merging tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
Automatic merge failed; fix conflicts and then commit the result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1228: TajoClient should communicate with o...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/317#issuecomment-68678042
+1
I tested the patch on tpc-h cluster. Queries ran successfully and codes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1228: TajoClient should communicate with o...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/317#issuecomment-68144407
I've rebased it. Thanks1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1228: TajoClient should communicate with o...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/317#issuecomment-68144562
Thanks @hyunsik, I merged the patch successfully. I'll start to review it. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---