You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2026/01/19 16:54:44 UTC

[PR] Add qumat dependency to qumat-qdp package [mahout]

guan404ming opened a new pull request, #875:
URL: https://github.com/apache/mahout/pull/875

   ### Purpose of PR
   
   - Add `qumat>0.4.0` as a dependency of `qumat-qdp` to ensure users always get the main package when installing the extension                          
   - Bump qumat version to `0.5.0.dev0` for development                                                                                                  
   - Update lock files
   
   ### Related Issues or PRs
   <!-- Add links to related issues or PRs. -->
   <!-- - Closes #123  -->
   - Related to #866
   
   ### Changes Made
   <!-- Please mark one with an "x"   -->
   - [ ] Bug fix
   - [ ] New feature
   - [ ] Refactoring
   - [ ] Documentation
   - [ ] Test
   - [ ] CI/CD pipeline
   - [x] Other
   
   ### Breaking Changes
   <!-- Does this PR introduce a breaking change? -->
   - [ ] Yes
   - [x] No
   
   ### Checklist
   <!-- Please mark each item with an "x" when complete -->
   <!-- If not all items are complete, please open this as a **Draft PR**.
   Once all requirements are met, mark as ready for review. -->
   
   - [x] Added or updated unit tests for all changes
   - [x] Added or updated documentation for all changes
   - [x] Successfully built and ran all unit tests or manual tests locally
   - [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
   - [x] Code follows ASF guidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add qumat dependency to qumat-qdp package [mahout]

Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #875:
URL: https://github.com/apache/mahout/pull/875#issuecomment-3769417880

   Is qumat-qdp becoming a distinct package from qumat? I saw this somewhere else too. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add qumat dependency to qumat-qdp package [mahout]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #875:
URL: https://github.com/apache/mahout/pull/875#issuecomment-3769480083

   Here is the discussion thread https://github.com/apache/mahout/discussions/876


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add qumat dependency to qumat-qdp package [mahout]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #875:
URL: https://github.com/apache/mahout/pull/875#issuecomment-3769477337

   Yes, pip install qumat[qdp] is exactly what we're going for. However, the extra still requires a separate package because extras are just dependencies on other packages, not embedded optional code. Also the extra still requires a separate package since 
                                                                                                                                                            
   - qumat uses hatchling (pure Python)                                                                                                                  
   - qumat-qdp uses maturin (Rust extension)                                                                                                             
   - A single pyproject.toml can only have one build backend 
   
   This follows the same pattern as pydantic + pydantic-core.                                                                                            
   Happy to document this in an ADR if you think it would be helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add qumat dependency to qumat-qdp package [mahout]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #875:
URL: https://github.com/apache/mahout/pull/875#issuecomment-3769377542

   cc @400Ping @viiccwen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add qumat dependency to qumat-qdp package [mahout]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #875:
URL: https://github.com/apache/mahout/pull/875#issuecomment-3769632091

   Feel free to open pr to refine this, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add qumat dependency to qumat-qdp package [mahout]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming merged PR #875:
URL: https://github.com/apache/mahout/pull/875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org