[GitHub] [incubator-age] emotionbug commented on a change in pull request #185: feat: Introduce `enable_auto_column_conversion`

[GitBox <gi...@apache.org>]

emotionbug commented on a change in pull request #185:
URL: https://github.com/apache/incubator-age/pull/185#discussion_r807441412



##########
File path: src/backend/parser/cypher_analyze.c
##########
@@ -612,10 +623,18 @@ static Query *analyze_cypher_and_coerce(List *stmt, RangeTblFunction *rtfunc,
     // check the number of attributes first
     if (attr_count != rtfunc->funccolcount)
     {
-        ereport(ERROR,
-                (errcode(ERRCODE_DATATYPE_MISMATCH),
-                 errmsg("return row and column definition list do not match"),
-                 parser_errposition(pstate, exprLocation(rtfunc->funcexpr))));
+        if (age_guc_enable_auto_column_conversion)

Review comment:
       Regarding this logic, it's a little uncomfortable while using it, so I'll revise it as follows.
   If the corresponding flag is set, it automatically matches regardless of the number of columns, otherwise, if the number of columns does not match, it will cause an error as before.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org