You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/07 03:52:23 UTC
[GitHub] [incubator-yunikorn-k8shim] wilfred-s opened a new pull request #189: [YUNIKORN-397] Makefile use go version from go.mod
wilfred-s opened a new pull request #189:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/189
Instead of hard coding a go version in the Makefile use the version
from the go.mod file. The build will fail if the installed tools version
is lower than the version from the go.mod file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #189: [YUNIKORN-397] Makefile use go version from go.mod
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #189:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #189: [YUNIKORN-397] Makefile use go version from go.mod
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/189#issuecomment-688032037
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=desc) (2225b7d) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/9d79d22d65e3efcc87a9debf0def1a12e1d92736?el=desc) (9d79d22) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 57.93% 57.95% +0.02%
==========================================
Files 33 33
Lines 3295 2928 -367
==========================================
- Hits 1909 1697 -212
+ Misses 1314 1158 -156
- Partials 72 73 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/common/events/recorder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXIuZ28=) | `30.00% <0.00%> (-6.37%)` | :arrow_down: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `66.82% <0.00%> (-5.15%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `81.81% <0.00%> (-2.53%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.88% <0.00%> (-2.03%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `32.73% <0.00%> (-1.64%)` | :arrow_down: |
| [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `83.83% <0.00%> (-1.53%)` | :arrow_down: |
| [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `83.49% <0.00%> (-1.51%)` | :arrow_down: |
| [pkg/cache/nodes.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `79.80% <0.00%> (-1.39%)` | :arrow_down: |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `79.10% <0.00%> (-1.29%)` | :arrow_down: |
| [pkg/cache/context\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHRfcmVjb3ZlcnkuZ28=) | `46.34% <0.00%> (-0.98%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=footer). Last update [9d79d22...2225b7d](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #189: [YUNIKORN-397] Makefile use go version from go.mod
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #189:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/189#issuecomment-732312201
@wilfred-s could you pls update the core dependency in this PR to re-trigger the e2e tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #189: [YUNIKORN-397] Makefile use go version from go.mod
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #189:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/189#issuecomment-688032037
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=desc) (261e559) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/9d79d22d65e3efcc87a9debf0def1a12e1d92736?el=desc) (9d79d22) will **increase** coverage by `0.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 57.93% 58.61% +0.67%
==========================================
Files 33 33
Lines 3295 3303 +8
==========================================
+ Hits 1909 1936 +27
+ Misses 1314 1295 -19
Partials 72 72
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `67.78% <0.00%> (-4.19%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `37.55% <0.00%> (+5.29%)` | :arrow_up: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `27.27% <0.00%> (+11.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=footer). Last update [9d79d22...2225b7d](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #189: [YUNIKORN-397] Makefile use go version from go.mod
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #189:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/189#issuecomment-688032037
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=h1) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/9d79d22d65e3efcc87a9debf0def1a12e1d92736?el=desc) will **increase** coverage by `0.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 57.93% 58.61% +0.67%
==========================================
Files 33 33
Lines 3295 3303 +8
==========================================
+ Hits 1909 1936 +27
+ Misses 1314 1295 -19
Partials 72 72
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `67.78% <0.00%> (-4.19%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `37.55% <0.00%> (+5.29%)` | :arrow_up: |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `27.27% <0.00%> (+11.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=footer). Last update [9d79d22...261e559](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #189: [YUNIKORN-397] Makefile use go version from go.mod
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #189:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/189#issuecomment-736942217
Pushing changes to build in all 3 repos
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org