Re: [I] [C++] uniform identifiers naming style. [orc]

["ffacs (via GitHub)" <gi...@apache.org>]

ffacs commented on issue #1845:
URL: https://github.com/apache/orc/issues/1845#issuecomment-1997047395

   The following `.clang-tidy` file can help us to check naming styles mismatch.  And we can use `clang-tidy` to fix them.
   ```
   Checks: "-*,
           readability-identifier-naming,
   "
   
   CheckOptions:
     [
         { key: readability-identifier-naming.PrivateMemberSuffix,   value: "_"  },
     ]
   
   WarningsAsErrors: ''
   HeaderFilterRegex: ''
   FormatStyle:     none
   ```
   But there is a problem that some protected/public variables need to be initialized on construction, what should the naming of 
   corresponding parameter should be? What do you think? @wgtmac @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org