You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2015/12/15 02:10:04 UTC
Re: Review Request 41244: Using 'git rev-parse --git-dir' in
post-reviews.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41244/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 1:10 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
Summary (updated)
-----------------
Using 'git rev-parse --git-dir' in post-reviews.py.
Bugs: MESOS-4125
https://issues.apache.org/jira/browse/MESOS-4125
Repository: mesos
Description
-------
The post-reviews.py script has similar problems to the bootstrap script
in assuming that .git is a folder in the top-level directory of the git
repo. This may not be true when mesos is included as a submodule in
another project. Use 'git rev-parse --git-dir' instead.
Diffs
-----
support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e
Diff: https://reviews.apache.org/r/41244/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 41244: Using 'git rev-parse --git-dir' in
post-reviews.py.
Posted by Till Toenshoff <to...@me.com>.
> On Dec. 17, 2015, 3:43 a.m., Till Toenshoff wrote:
> > Ship It!
I noted some of your recent reviews contain the review-request link in the description shown on RB (this one doesnt) - can you please make sure its not anything your own recent changes are related to, thanks.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41244/#review110884
-----------------------------------------------------------
On Dec. 17, 2015, 3:44 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41244/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 3:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-4125
> https://issues.apache.org/jira/browse/MESOS-4125
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The post-reviews.py script has similar problems to the bootstrap script
> in assuming that .git is a folder in the top-level directory of the git
> repo. This may not be true when mesos is included as a submodule in
> another project. Use 'git rev-parse --git-dir' instead.
>
>
> Diffs
> -----
>
> support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e
>
> Diff: https://reviews.apache.org/r/41244/diff/
>
>
> Testing
> -------
>
> I have been posting all of my reviews with this script since first creating this commit. Tested both in an environment with and without mesos embedded as a submodule inside another git repository.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 41244: Using 'git rev-parse --git-dir' in
post-reviews.py.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41244/#review110884
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Dec. 17, 2015, 3:07 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41244/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 3:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
>
>
> Bugs: MESOS-4125
> https://issues.apache.org/jira/browse/MESOS-4125
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The post-reviews.py script has similar problems to the bootstrap script
> in assuming that .git is a folder in the top-level directory of the git
> repo. This may not be true when mesos is included as a submodule in
> another project. Use 'git rev-parse --git-dir' instead.
>
>
> Diffs
> -----
>
> support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e
>
> Diff: https://reviews.apache.org/r/41244/diff/
>
>
> Testing
> -------
>
> I have been posting all of my reviews with this script since first creating this commit. Tested both in an environment with and without mesos embedded as a submodule inside another git repository.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 41244: Using 'git rev-parse --git-dir' in
post-reviews.py.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41244/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 3:07 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Vinod Kone.
Bugs: MESOS-4125
https://issues.apache.org/jira/browse/MESOS-4125
Repository: mesos
Description
-------
The post-reviews.py script has similar problems to the bootstrap script
in assuming that .git is a folder in the top-level directory of the git
repo. This may not be true when mesos is included as a submodule in
another project. Use 'git rev-parse --git-dir' instead.
Diffs
-----
support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e
Diff: https://reviews.apache.org/r/41244/diff/
Testing (updated)
-------
I have been posting all of my reviews with this script since first creating this commit. Tested both in an environment with and without mesos embedded as a submodule inside another git repository.
Thanks,
Kevin Klues