You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2018/02/23 09:52:11 UTC

[GitHub] brooklyn-server pull request #952: [BROOKLYN-584] Add support for recent jcl...

GitHub user andreaturli opened a pull request:

    https://github.com/apache/brooklyn-server/pull/952

    [BROOKLYN-584] Add support for recent jclouds's ContextLinking

    - add support for user-defined Guice modules
    - add support for ContextLinking
    - simplify feature.xml to use pre-defined jclouds-karaf features

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andreaturli/brooklyn-server feature/linkContext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/952.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #952
    
----
commit c3214e9f1eb4904a427a68afc3ccb4f8a4a1e387
Author: andreaturli <an...@...>
Date:   2017-12-12T16:48:07Z

    [BROOKLYN-584] Add support for recent jclouds's ContextLinking
    
    - add support for user-defined Guice modules
    - add support for ContextLinking
    - simplify feature.xml to use pre-defined jclouds-karaf features

----


---

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:

    https://github.com/apache/brooklyn-server/pull/952
  
    thanks @duncangrant and @geomacy 
    
    Do you guys think the docs should be part of the same PR?


---

[GitHub] brooklyn-server pull request #952: [BROOKLYN-584] Add support for recent jcl...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/952


---

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the issue:

    https://github.com/apache/brooklyn-server/pull/952
  
    @andreaturli No - shouldn't be part of this PR.  I just wrote the comment as a reminder.


---

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the issue:

    https://github.com/apache/brooklyn-server/pull/952
  
    @andreaturli Might be worth adding a docs change to https://brooklyn.apache.org/v/latest/locations/index.html#openstack?


---

[GitHub] brooklyn-server issue #952: [BROOKLYN-584] Add support for recent jclouds's ...

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/952
  
    @andreaturli @duncangrant  I agree it shouldn't be part of this PR, just think it's worth documenting 


---