[GitHub] [accumulo] DomGarguilo commented on issue #947: Optimize generation of custom props map in ServiceEnvironmentImpl

[GitBox <gi...@apache.org>]

DomGarguilo commented on issue #947:
URL: https://github.com/apache/accumulo/issues/947#issuecomment-833838006


   After a bit of investigation, this may not be an issue. The proposed change is to cache the props map in question and only update it if the configuration changes. However, the props maps are only ever generated once, when they are null. Assuming this is correct, this may not be an issue.
   
   During my investigation I did look into the mentioned counter that is updated when AccumuloConfig changes however the getter for this counter AccumuloConfig.getUpdateCount() returns 0 instead of the counters value. It seems this variable is used as mentioned, to determine when to recompute or when to use the cached map. From what I can tell this is an error and will always cause the updateCounter comparisons to fail causing the props maps to be recomputed every time. I'm not certain whether this is behaving correctly or not so I wanted to get a second opinion. I'll create a separate issue if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org