You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Eugen Paraschiv (JIRA)" <ji...@apache.org> on 2010/06/29 21:17:12 UTC
[jira] Created: (DROIDS-90) Refactor static methods out of
functionality classes
Refactor static methods out of functionality classes
----------------------------------------------------
Key: DROIDS-90
URL: https://issues.apache.org/jira/browse/DROIDS-90
Project: Droids
Issue Type: Improvement
Components: core
Affects Versions: 0.0.1
Reporter: Eugen Paraschiv
Fix For: 0.0.1
There are static methods (main, utility methods) present in functionality classes:
Save - createFile
FileRenameDroid - main
SimpleWalkingDroid - main
These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-90) Refactor static methods out of
functionality classes
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv updated DROIDS-90:
----------------------------------
Attachment: DROIDS-90_1.patch
> Refactor static methods out of functionality classes
> ----------------------------------------------------
>
> Key: DROIDS-90
> URL: https://issues.apache.org/jira/browse/DROIDS-90
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-90_1.patch
>
>
> There are static methods (main, utility methods) present in functionality classes:
> SaveHandler - createFile
> FileRenameDroid - main
> SimpleWalkingDroid - main
> These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DROIDS-90) Refactor static methods out of
functionality classes
Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898557#action_12898557 ]
Javier Puerto commented on DROIDS-90:
-------------------------------------
Could you provide a patch for SaveHandler? I think that the classes in test should be untouched till we resolved the DROIDS-89 issue. The extracted method can be placed in a "FileUtil" class in package "org.apache.droids.helper".
> Refactor static methods out of functionality classes
> ----------------------------------------------------
>
> Key: DROIDS-90
> URL: https://issues.apache.org/jira/browse/DROIDS-90
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
>
> There are static methods (main, utility methods) present in functionality classes:
> Save - createFile
> FileRenameDroid - main
> SimpleWalkingDroid - main
> These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DROIDS-90) Refactor static methods out of
functionality classes
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv resolved DROIDS-90.
-----------------------------------
Resolution: Fixed
> Refactor static methods out of functionality classes
> ----------------------------------------------------
>
> Key: DROIDS-90
> URL: https://issues.apache.org/jira/browse/DROIDS-90
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-90_1.patch
>
>
> There are static methods (main, utility methods) present in functionality classes:
> SaveHandler - createFile
> FileRenameDroid - main
> SimpleWalkingDroid - main
> These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-90) Refactor static methods out of
functionality classes
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv updated DROIDS-90:
----------------------------------
Description:
There are static methods (main, utility methods) present in functionality classes:
SaveHandler - createFile
FileRenameDroid - main
SimpleWalkingDroid - main
These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
was:
There are static methods (main, utility methods) present in functionality classes:
Save - createFile
FileRenameDroid - main
SimpleWalkingDroid - main
These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
> Refactor static methods out of functionality classes
> ----------------------------------------------------
>
> Key: DROIDS-90
> URL: https://issues.apache.org/jira/browse/DROIDS-90
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
>
> There are static methods (main, utility methods) present in functionality classes:
> SaveHandler - createFile
> FileRenameDroid - main
> SimpleWalkingDroid - main
> These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DROIDS-90) Refactor static methods out of
functionality classes
Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898566#action_12898566 ]
Javier Puerto commented on DROIDS-90:
-------------------------------------
Thanks Eugen. Seems like I commited the SaveHandler class with incorrectly format. I just added the ASF licence to FileUtil class. But, please review the path of the patches for further contributions.
Commited revision: r985466
> Refactor static methods out of functionality classes
> ----------------------------------------------------
>
> Key: DROIDS-90
> URL: https://issues.apache.org/jira/browse/DROIDS-90
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-90_1.patch
>
>
> There are static methods (main, utility methods) present in functionality classes:
> SaveHandler - createFile
> FileRenameDroid - main
> SimpleWalkingDroid - main
> These should be refactored out of the functionality classes - the createFile method should be in an utility class and the main methods in the examples and documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.