You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/26 22:14:02 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11432: feat: annotation layers CRUD list view

codecov-io edited a comment on pull request #11432:
URL: https://github.com/apache/incubator-superset/pull/11432#issuecomment-716852597


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11432?src=pr&el=h1) Report
   > Merging [#11432](https://codecov.io/gh/apache/incubator-superset/pull/11432?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/604a519d8b2e530b3b6a83ee3795ce0813f24ef8?el=desc) will **decrease** coverage by `4.99%`.
   > The diff coverage is `72.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11432/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11432?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11432      +/-   ##
   ==========================================
   - Coverage   66.62%   61.63%   -5.00%     
   ==========================================
     Files         860      416     -444     
     Lines       40881    25912   -14969     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        27238    15971   -11267     
   + Misses      13545     9941    -3604     
   + Partials       98        0      -98     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.63% <72.72%> (-0.30%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11432?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `82.14% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <72.72%> (-1.49%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.38% <0.00%> (-3.36%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.07% <0.00%> (-3.07%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <0.00%> (-2.84%)` | :arrow_down: |
   | ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11432/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11432?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11432?src=pr&el=footer). Last update [604a519...e652270](https://codecov.io/gh/apache/incubator-superset/pull/11432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org