[jira] Updated: (TAP5-1201) PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)

["Kalle Korhonen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kalle Korhonen updated TAP5-1201:
---------------------------------

    Attachment: TAP5-1201.patch

Apply patch to the root of tapestry-core. There's no unit test for now as I was unsure which one of these would be the best option:
1) Add a unit test to ComponentSourceImplTest
2) Create a new unit test class PageResponseRendererImplTest and implement a unit test similar to ComponentSourceImplTest.get_active_page()
3) A functional test, where?
4) This functionality shouldn't be added in, instead you should do X 

It's an easy addition and I really would like to resolve this one way or another. If you think this is incorrect, I don't mind as long as you point me towards a proper solution.

> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName) 
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1201
>                 URL: https://issues.apache.org/jira/browse/TAP5-1201
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0
>            Reporter: Kalle Korhonen
>            Priority: Minor
>         Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs.  As currently coded, we assume that the active page is identified by the component event or page render dispatcher."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.