[jira] [Commented] (CLOUDSTACK-2515) KVM Agent iterates all libvirt storage pools and hits a nullpointer exception on RBD pools

["Wido den Hollander (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658272#comment-13658272 ] 

Wido den Hollander commented on CLOUDSTACK-2515:
------------------------------------------------

I'm already preparing a fix. It's just a small if statement
                
> KVM Agent iterates all libvirt storage pools and hits a nullpointer exception on RBD pools
> ------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-2515
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2515
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.1.0, 4.2.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>            Priority: Blocker
>             Fix For: 4.1.1
>
>
> Commit 6928679ba834bb8bb404d6e87c07f34a6f047884 made storage pools non-persistent, but it also makes the assumption that every storage pool has a targetPath eg, where it is mounted.
> RBD storage pools do not have this and when LibvirtStorageAdapter iterates all pools it does a check on the targetPath, which leads to a NullPointerException on RBD pools.
> The piece of code:
> StoragePool p = conn.storagePoolLookupByName(poolname);
> LibvirtStoragePoolDef pdef = getStoragePoolDef(conn, p);
> if (pdef.getTargetPath().equals(path)) {
> ..
> }
> This is a BLOCKER for 4.1, since it doesn't allow you to deploy from ISO's when you have a RBD storage pool, even when you are not deploying on that pool.
> Link to the commit: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=6928679ba834bb8bb404d6e87c07f34a6f047884

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira