You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/09/22 18:51:05 UTC
[GitHub] beam pull request #3888: [BEAM-2982] Use the SubscriptionProvider in PubsubU...
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/3888
[BEAM-2982] Use the SubscriptionProvider in PubsubUnboundedSource
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
During expansion, a ValueProvider may not be accessible. This ensures
that if the subscription is based on a value provider, it will only be
evaluated when that ValueProvider is bound, rather than at construction
time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam b_2982
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3888.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3888
----
commit 23e56d0dee8c70b33eb0364a1cde94125399dadf
Author: Thomas Groh <tg...@google.com>
Date: 2017-09-22T18:47:19Z
Use the SubscriptionProvider in PubsubUnboundedSource
During expansion, a ValueProvider may not be accessible. This ensures
that if the subscription is based on a value provider, it will only be
evaluated when that ValueProvider is bound, rather than at construction
time.
----
---
[GitHub] beam pull request #3888: [BEAM-2982] Use the SubscriptionProvider in PubsubU...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3888
---