You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/05/15 08:25:25 UTC
[PR] fix: raise when presigned URL response is missing or malformed [texera]
Ma77Ball opened a new pull request, #5073:
URL: https://github.com/apache/texera/pull/5073
### What changes were proposed in this PR?
`DatasetFileDocument.get_presigned_url` previously returned `response.json().get("presignedUrl")` on a 200 response, so a body that omitted the key (or wasn't valid JSON) silently returned `None`. This PR parses the JSON inside a try/except block and validates that `presignedUrl` is a non-empty string; otherwise, it raises `RuntimeError` with the response body.
### Any related issues, documentation, or discussions?
Closes: #4725
### How was this PR tested?
Manually reproduced the missing-key case (mocked 200 + empty JSON) and confirmed the new `RuntimeError` is raised at the presign step instead of a downstream `requests.get(None)` failure.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: raise when presigned URL response is missing or malformed [texera]
Posted by "aicam (via GitHub)" <gi...@apache.org>.
aicam merged PR #5073:
URL: https://github.com/apache/texera/pull/5073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: raise when presigned URL response is missing or malformed [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5073:
URL: https://github.com/apache/texera/pull/5073#issuecomment-4458217327
/request-review @aicam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: raise when presigned URL response is missing or malformed [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5073:
URL: https://github.com/apache/texera/pull/5073#issuecomment-4458756075
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5073?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.00000%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.05%. Comparing base ([`1ea368d`](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`44b386c`](https://app.codecov.io/gh/apache/texera/commit/44b386caeecb3abb954b970bc312e194aa72e917?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/5073?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/python/pytexera/storage/dataset\_file\_document.py](https://app.codecov.io/gh/apache/texera/pull/5073?src=pr&el=tree&filepath=amber%2Fsrc%2Fmain%2Fpython%2Fpytexera%2Fstorage%2Fdataset_file_document.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1iZXIvc3JjL21haW4vcHl0aG9uL3B5dGV4ZXJhL3N0b3JhZ2UvZGF0YXNldF9maWxlX2RvY3VtZW50LnB5) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/5073?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5073 +/- ##
=========================================
Coverage 43.05% 43.05%
Complexity 2207 2207
=========================================
Files 1045 1045
Lines 40216 40223 +7
Branches 4243 4243
=========================================
+ Hits 17315 17320 +5
- Misses 21832 21834 +2
Partials 1069 1069
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.72% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.77% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.93% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.33% <75.00%> (-0.04%)` | :arrow_down: | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5073/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.72% <ø> (ø)` | | Carriedforward from [1ea368d](https://app.codecov.io/gh/apache/texera/commit/1ea368dc71a232995e8c9462eda33d61f69036af?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5073?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org