You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/14 14:26:10 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request #5493: stm32h7:Flash fixes from 328374f4658d11655f268f968f4c6c7a3942f320
davids5 opened a new pull request #5493:
URL: https://github.com/apache/incubator-nuttx/pull/5493
## Summary
The first commit fixes lock violations: commit 328374f4658d11655f268f968f4c6c7a3942f320 added code that exited with out releasing exclusive lock and left the flash unlocked.
Second commit fixes write performance: commit 328374f4658d11655f268f968f4c6c7a3942f320 used usleep and bases on the +1 and quantization slowed the writes speed to a crawl. This was apparent in the second bank programing.
## Impact
Balanced lock and unlock restored.
Write performance restored.
Trade off: We could add a Kconfig to allow for a choice of FLASH Write performance vs. Real time response performance . But the wait is typically < 100uS and there seems to be a growing Kconfig reduction effort.
## Testing
PX4 V6X bootloader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5493: stm32h7:Flash fixes from 328374f4658d11655f268f968f4c6c7a3942f320
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5493:
URL: https://github.com/apache/incubator-nuttx/pull/5493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #5493: stm32h7:Flash fixes from 328374f4658d11655f268f968f4c6c7a3942f320
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #5493:
URL: https://github.com/apache/incubator-nuttx/pull/5493#issuecomment-1039317266
@acassis - please merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5493: stm32h7:Flash fixes from 328374f4658d11655f268f968f4c6c7a3942f320
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5493:
URL: https://github.com/apache/incubator-nuttx/pull/5493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #5493: stm32h7:Flash fixes from 328374f4658d11655f268f968f4c6c7a3942f320
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #5493:
URL: https://github.com/apache/incubator-nuttx/pull/5493#issuecomment-1039317266
@acassis - please merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org